Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing melange.module and bs.module payloads for assets #477

Closed
jchavarri opened this issue Jan 20, 2023 · 1 comment
Closed

Allow passing melange.module and bs.module payloads for assets #477

jchavarri opened this issue Jan 20, 2023 · 1 comment

Comments

@jchavarri
Copy link
Member

jchavarri commented Jan 20, 2023

Considering that:

  • the placement of assets like images or fonts might change while migrating to Dune
  • some apps are large enough that they migrate some parts to Melange progressively, not in a one-shot commit

it would be nice to support passing two payloads for assets, e.g.:

external img : string = "default"
  [@@bs.module "../../public/assets/images/robot.svg"]
  [@@melange.module "../../../../../robot.svg"]

This would allow to proceed with progressive migrations without having to turn to conditional compilation. It would also set Melange up to progressively migrate to melange.X attributes over bs.* ones.

@jchavarri
Copy link
Member Author

I don't think this is needed anymore, as there is now support to copy any assets from any folder:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant