refactor(ts): Enforce noImplicitOverride and fix existing occurences (

#945)
melink14 · Apr 7, 2022 · 8e37e87 · 8e37e87
1 parent 2188e27
commit 8e37e87
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 14 deletions.
diff --git a/extension/options.ts b/extension/options.ts
@@ -11,7 +11,7 @@ type OptionEvent = {
 class OptionsForm extends LitElement {
   private content: Promise<TemplateResult> = this.fetchAndRender();
 
-  render() {
+  override render() {
     return html`${until(this.content)}<lit-toast></lit-toast>`;
   }
 
@@ -333,7 +333,7 @@ class OptionsForm extends LitElement {
     `;
   }
 
-  static styles = css`
+  static override styles = css`
     #rikaikun-options,
     #rikaikun-options td {
       font-family: sans-serif;

diff --git a/tsconfig.json b/tsconfig.json
@@ -11,6 +11,7 @@
     "forceConsistentCasingInFileNames": true,
     "noEmitOnError": true,
     "noFallthroughCasesInSwitch": true,
+    "noImplicitOverride": true,
     "noImplicitReturns": true,
     "pretty": true,
     "sourceMap": true,

diff --git a/utils/update-db.ts b/utils/update-db.ts
@@ -114,12 +114,12 @@ class DictParser extends Transform {
     super(options);
   }
 
-  /**
-   * Transforms data
-   *
-   * @override
-   */
-  _transform(data: Buffer, encoding: string, callback: TransformCallback) {
+  /** Transforms data */
+  override _transform(
+    data: Buffer,
+    encoding: string,
+    callback: TransformCallback
+  ) {
     const line = data.toString('utf8');
 
     // Skip the header
@@ -231,12 +231,8 @@ class KanjiDictParser extends Writable {
     this.#heisigData = options.heisigData;
   }
 
-  /**
-   * Write the data.
-   *
-   * @override
-   */
-  _write(
+  /** Write the data. */
+  override _write(
     chunk: Buffer,
     encoding: string,
     callback: (error?: Error | null) => void