New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow native library dependencies to be loaded from nuget runtime folders #11

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@mjjames
Contributor

mjjames commented Oct 30, 2018

Fixes #10
I have written a test but as its a thrid party Nuget thats not in the open I can't submit it with it. It's a fairly simple change however.
Unless you know of any nuget's with native runtime libraries that have dependencies in the same folder....

mellinoe and others added some commits Oct 30, 2018

Michael James
if a nuget package has a nativelibrary that also has a dependency tha…
…ts distributed within the same runtime folder ensure the directory the nativelibrary is loaded from is checked before carrying on down the usual search path.
@mellinoe

This comment has been minimized.

Owner

mellinoe commented Nov 4, 2018

@mjjames Thanks for the submission. It seems like this will work for Windows, but not elsewhere. Reading around, it seems like there could be a similar problem on other platforms. Is there a way to fix this for the libdl-based loader?

@mjjames

This comment has been minimized.

Contributor

mjjames commented Nov 5, 2018

I'll look into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment