From c49cf26a3461ca440c7ece7d4b11697c302aa3d7 Mon Sep 17 00:00:00 2001 From: Jader Dias Date: Wed, 29 Mar 2017 12:00:08 +0200 Subject: [PATCH] Fix for CPAN Testers failures There will be always even fasters servers out there. This fix is future-proof because it doesn't compare the CPU usage against some absolute threshold, but against the same machine's benchmark when it was idle. This commit is part of the CPAN Pull Request Challenge. Signed-off-by: Jader Dias --- proc-cpuusage/t/01-usage.t | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/proc-cpuusage/t/01-usage.t b/proc-cpuusage/t/01-usage.t index 8a3b1f1..73a2f31 100644 --- a/proc-cpuusage/t/01-usage.t +++ b/proc-cpuusage/t/01-usage.t @@ -9,12 +9,12 @@ my $usage; my $cpu = Proc::CPUUsage->new; ok($cpu); sleep(1); -$usage = $cpu->usage; -ok($usage < .1, "Sleepy process, little usage ($usage)"); +my $little_usage = $cpu->usage; +ok($little_usage < .1, "Sleepy process, little usage ($little_usage)"); for (my $i = 0; $i < 500_000; $i++) {}; -$usage = $cpu->usage; -ok($usage > .5, "Active process, big usage ($usage)"); +my $big_usage = $cpu->usage; +ok($big_usage > $little_usage, "Active process, big usage ($big_usage) > little usage ($little_usage)"); ## No support for getrusage() my @bad_replies = (