Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update visibility flag for floating objects based on the object coordinates #943

Closed
obiot opened this issue Jul 31, 2018 · 0 comments
Closed

update visibility flag for floating objects based on the object coordinates #943

obiot opened this issue Jul 31, 2018 · 0 comments

Comments

@obiot
Copy link
Member

obiot commented Jul 31, 2018

melonJS version

6.0

Bug description

setting a floating object coordinates outside of the viewport will not change its visibility flag.

see this forum
http://www.html5gamedevs.com/topic/39116-hidden-gui-objects-slow-game-render/
obiot added a commit that referenced this issue Sep 27, 2018
@obiot
move the test on floating coordinates to the me.Camera2d.isVisible() …
571264e 
…function

also allow for #943 to be fixed in a single place, and makes other code cleaner
obiot added a commit that referenced this issue Oct 26, 2018
@obiot
[#943] update visibility flag for floating objects using actual scree…
53a9683 
…n coordinates

as opposed to the "return true" shortcut previously implemented
@obiot obiot closed this as completed Oct 26, 2018
obiot added a commit that referenced this issue Oct 28, 2018
@obiot
[#943] fix a regression with nested containers and floating objects
d57fee8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@obiot