This repository has been archived by the owner. It is now read-only.

Depecrate "from" parameter often passed as last argument #131

Closed
jennazenk opened this Issue Jan 5, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@jennazenk
Member

jennazenk commented Jan 5, 2018

Can be replaced by wallet.address

@schmidsi

This comment has been minimized.

Show comment
Hide comment
@schmidsi

schmidsi Jan 5, 2018

Member

Actually I did not really understand why we explicitly added it in the first place (I think it was inconsistent inside web3.js when defaultAccount was used and when not). But with the address coming from wallet it is much cleaner.

Member

schmidsi commented Jan 5, 2018

Actually I did not really understand why we explicitly added it in the first place (I think it was inconsistent inside web3.js when defaultAccount was used and when not). But with the address coming from wallet it is much cleaner.

@jennazenk

This comment has been minimized.

Show comment
Hide comment
@jennazenk

jennazenk Jan 9, 2018

Member

Fixed here #137

Member

jennazenk commented Jan 9, 2018

Fixed here #137

@jennazenk jennazenk closed this Jan 9, 2018

@schmidsi schmidsi referenced this issue Jan 11, 2018

Merged

Parity exp #140

@jennazenk jennazenk referenced this issue Jan 18, 2018

Merged

0.6.0 #152

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.