Permalink
Commits on Nov 23, 2011
  1. Remove user-selectable ANALYZE option for range types.

    tglsfdc committed Nov 23, 2011
    It's not clear that a per-datatype typanalyze function would be any more
    useful than a generic typanalyze for ranges.  What *is* clear is that
    letting unprivileged users select typanalyze functions is a crash risk or
    worse.  So remove the option from CREATE TYPE AS RANGE, and instead put in
    a generic typanalyze function for ranges.  The generic function does
    nothing as yet, but hopefully we'll improve that before 9.2 release.
  2. Remove zero- and one-argument range constructor functions.

    tglsfdc committed Nov 23, 2011
    Per discussion, the zero-argument forms aren't really worth the catalog
    space (just write 'empty' instead).  The one-argument forms have some use,
    but they also have a serious problem with looking too much like functional
    cast notation; to the point where in many real use-cases, the parser would
    misinterpret what was wanted.
    
    Committing this as a separate patch, with the thought that we might want
    to revert part or all of it if we can think of some way around the cast
    ambiguity.
Commits on Nov 22, 2011
  1. Improve implementation of range-contains-element tests.

    tglsfdc committed Nov 22, 2011
    Implement these tests directly instead of constructing a singleton range
    and then applying range-contains.  This saves a range serialize/deserialize
    cycle as well as a couple of redundant bound-comparison steps, and adds
    very little code on net.
    
    Remove elem_contained_by_range from the GiST opclass: it doesn't belong
    there because there is no way to use it in an index clause (where the
    indexed column would have to be on the left).  Its commutator is in the
    opclass, and that's what counts.
  2. Check for INSERT privileges in SELECT INTO / CREATE TABLE AS.

    Robert Haas
    Robert Haas committed Nov 22, 2011
    In the normal course of events, this matters only if ALTER DEFAULT
    PRIVILEGES has been used to revoke default INSERT permission.  Whether
    or not the new behavior is more or less likely to be what the user wants
    when dealing only with the built-in privilege facilities is arguable,
    but it's clearly better when using a loadable module such as sepgsql
    that may use the hook in ExecCheckRTPerms to enforce additional
    permissions checks.
    
    KaiGai Kohei, reviewed by Albe Laurenz
  3. Still more review for range-types patch.

    tglsfdc committed Nov 22, 2011
    Per discussion, relax the range input/construction rules so that the
    only hard error is lower bound > upper bound.  Cases where the lower
    bound is <= upper bound, but the range nonetheless normalizes to empty,
    are now permitted.
    
    Fix core dump in range_adjacent when bounds are infinite.  Marginal
    cleanup of regression test cases, some more code commenting.
  4. Continue to allow VACUUM to mark last block of index dirty

    simonat2ndQuadrant committed Nov 22, 2011
    even when there is no work to do. Further analysis required.
    Revert of patch c1458cc
Commits on Nov 21, 2011
  1. More code review for rangetypes patch.

    tglsfdc committed Nov 21, 2011
    Fix up some infelicitous coding in DefineRange, and add some missing error
    checks.  Rearrange operator strategy number assignments for GiST anyrange
    opclass so that they don't make such a mess of opr_sanity's table of
    operator names associated with different strategy numbers.  Assign
    hopefully-temporary selectivity estimators to range operators that didn't
    have one --- poor as the estimates are, they're still a lot better than the
    default 0.5 estimate, and they'll shut up the opr_sanity test that wants to
    see selectivity estimators on all built-in operators.
  2. Fix citext upgrade script to update derived copies of pg_type.typcoll…

    tglsfdc committed Nov 21, 2011
    …ation.
    
    If the existing citext type has not merely been created, but used in any
    tables, then the upgrade script wasn't doing enough.  We have to update
    attcollation for each citext table column, and indcollation for each citext
    index column, as well.  Per report from Rudolf van der Leeden.
  3. Further code review for range types patch.

    tglsfdc committed Nov 21, 2011
    Fix some bugs in coercion logic and pg_dump; more comment cleanup;
    minor cosmetic improvements.
Commits on Nov 19, 2011
  1. Avoid floating-point underflow while tracking buffer allocation rate.

    tglsfdc committed Nov 19, 2011
    When the system is idle for awhile after activity, the "smoothed_alloc"
    state variable in BgBufferSync converges slowly to zero.  With standard
    IEEE float arithmetic this results in several iterations with denormalized
    values, which causes kernel traps and annoying log messages on some
    poorly-designed platforms.  There's no real need to track such small values
    of smoothed_alloc, so we can prevent the kernel traps by forcing it to zero
    as soon as it's too small to be interesting for our purposes.  This issue
    is purely cosmetic, since the iterations don't happen fast enough for the
    kernel traps to pose any meaningful performance problem, but still it seems
    worth shutting up the log messages.
    
    The kernel log messages were previously reported by a number of people,
    but kudos to Greg Matthews for tracking down exactly where they were coming
    from.
Commits on Nov 18, 2011
  1. Further review of range-types patch.

    tglsfdc committed Nov 18, 2011
    Lots of documentation cleanup today, and still more type_sanity tests.
  2. Avoid marking buffer dirty when VACUUM has no work to do.

    simonat2ndQuadrant committed Nov 18, 2011
    When wal_level = 'hot_standby' we touched the last page of the
    relation during a VACUUM, even if nothing else had happened.
    That would alter the LSN of the last block and set the mtime
    of the relation file unnecessarily. Noted by Thom Brown.
  3. Remove scandir() requirement in pg_upgrade; instead just use readdir()

    bmomjian committed Nov 18, 2011
    --- we were not using the scandir pattern filtering anyway.  This also
    removes the scandir requirement in configure.
  4. Further consolidation of DROP statement handling.

    Robert Haas
    Robert Haas committed Nov 18, 2011
    This gets rid of an impressive amount of duplicative code, with only
    minimal behavior changes.  DROP FOREIGN DATA WRAPPER now requires object
    ownership rather than superuser privileges, matching the documentation
    we already have.  We also eliminate the historical warning about dropping
    a built-in function as unuseful.  All operations are now performed in the
    same order for all object types handled by dropcmds.c.
    
    KaiGai Kohei, with minor revisions by me
Commits on Nov 17, 2011
  1. Declare range inclusion operators as taking anyelement not anynonarray.

    tglsfdc committed Nov 17, 2011
    Use of anynonarray was a crude hack to get around ambiguity versus the
    array inclusion operators of the same names.  My previous patch to extend
    the parser's type resolution heuristics makes that unnecessary, so use
    the more general declaration instead.  This eliminates a wart that these
    operators couldn't be used with ranges over arrays, which are otherwise
    supported just fine.
    
    Also, mark range_before and range_after as commutator operators,
    per discussion with Jeff Davis.
  2. Extend the unknowns-are-same-as-known-inputs type resolution heuristic.

    tglsfdc committed Nov 17, 2011
    For a very long time, one of the parser's heuristics for resolving
    ambiguous operator calls has been to assume that unknown-type literals are
    of the same type as the other input (if it's known).  However, this was
    only used in the first step of quickly checking for an exact-types match,
    and thus did not help in resolving matches that require coercion, such as
    matches to polymorphic operators.  As we add more polymorphic operators,
    this becomes more of a problem.  This patch adds another use of the same
    heuristic as a last-ditch check before failing to resolve an ambiguous
    operator or function call.  In particular this will let us define the range
    inclusion operator in a less limited way (to come in a follow-on patch).
  3. Fix range_cmp_bounds for the case of equal-valued exclusive bounds.

    tglsfdc committed Nov 17, 2011
    Also improve its comments and related regression tests.
    
    Jeff Davis, with some further adjustments by Tom
  4. Don't quote language name

    alvherre committed Nov 17, 2011
    Same as previous patch, but give it actual thought this time
  5. Don't quote language name

    alvherre committed Nov 17, 2011
    It's been deprecated for ages according to Tom, and it breaks now given
    the previous patch anyway.
    
    Per buildfarm
  6. Remove ancient downcasing code from procedural language operations.

    Robert Haas
    Robert Haas committed Nov 17, 2011
    A very long time ago, language names were specified as literals rather
    than identifiers, so this code was added to do case-folding.  But that
    style has ben deprecated for many years so this isn't needed any more.
    Language names will still be downcased when specified as unquoted
    identifiers, but quoted identifiers or the old style using string
    literals will be left as-is.
  7. Fix pg_upgrade's pg_scandir_internal() to properly handle a NULL

    bmomjian committed Nov 17, 2011
    pattern, which is used on PG 9.1 and HEAD (but not pre-9.1).  Fixes
    crash on Windows.
    
    Backpatched to 9.1.
    
    Reported by Mark Dilger
  8. Restructure get_object_address() so it's safe against concurrent DDL.

    Robert Haas
    Robert Haas committed Nov 17, 2011
    This gives a much better error message when the object of interest is
    concurrently dropped and avoids needlessly failing when the object of
    interest is concurrently dropped and recreated.  It also improves the
    behavior of two concurrent DROP IF EXISTS operations targeted at the
    same object; as before, one will drop the object, but now the other
    will emit the usual NOTICE indicating that the object does not exist,
    instead of rolling back.  As a fringe benefit, it's also slightly
    less code.
  9. Applied Zoltan's patch to correctly align interval and timestamp data…

    Michael Meskes
    Michael Meskes committed Nov 17, 2011
    … in ecpg's sqlda.
Commits on Nov 16, 2011
  1. Code review for range-types catalog entries.

    tglsfdc committed Nov 16, 2011
    Fix assorted infelicities, such as dependency on OIDs that aren't
    hardwired, as well as outright misdeclaration of daterange_canonical(),
    which resulted in crashes if you invoked it directly.  Add some more
    regression tests to try to catch similar mistakes in future.
  2. Don't elide blank lines when accumulating psql command history.

    Robert Haas
    Robert Haas committed Nov 16, 2011
    This can change the meaning of queries, if the blank line happens to
    occur in the middle of a quoted literal, as per complaint from Tomas Vondra.
    
    Back-patch to all supported branches.
Commits on Nov 15, 2011
  1. Improve caching in range type I/O functions.

    tglsfdc committed Nov 15, 2011
    Cache the the element type's I/O info across calls, not only the range
    type's info.  In passing, also clean up hash_range a bit more.
  2. Restructure function-internal caching in the range type code.

    tglsfdc committed Nov 15, 2011
    Move the responsibility for caching specialized information about range
    types into the type cache, so that the catalog lookups only have to occur
    once per session.  Rearrange APIs a bit so that fn_extra caching is
    actually effective in the GiST support code.  (Use of OidFunctionCallN is
    bad enough for performance in itself, but it also prevents the function
    from exploiting fn_extra caching.)
    
    The range I/O functions are still not very bright about caching repeated
    lookups, but that seems like material for a separate patch.
    
    Also, avoid unnecessary use of memcpy to fetch/store the range type OID and
    flags, and don't use the full range_deserialize machinery when all we need
    to see is the flags value.
    
    Also fix API error in range_gist_penalty --- it was failing to set *penalty
    for any case involving an empty range.
  3. Fix alignment and toasting bugs in range types.

    tglsfdc committed Nov 15, 2011
    A range type whose element type has 'd' alignment must have 'd' alignment
    itself, else there is no guarantee that the element value can be used
    in-place.  (Because range_deserialize uses att_align_pointer which forcibly
    aligns the given pointer, violations of this rule did not lead to SIGBUS
    but rather to garbage data being extracted, as in one of the added
    regression test cases.)
    
    Also, you can't put a toast pointer inside a range datum, since the
    referenced value could disappear with the range datum still present.
    For consistency with the handling of arrays and records, I also forced
    decompression of in-line-compressed bound values.  It would work to store
    them as-is, but our policy is to avoid situations that might result in
    double compression.
    
    Add assorted regression tests for this, and bump catversion because of
    fixes to built-in pg_type entries.
    
    Also some marginal cleanup of inconsistent/unnecessary error checks.
  4. Update oidjoins regression test to match git HEAD.

    tglsfdc committed Nov 15, 2011
    This is mostly to add some sanity checking for the pg_range catalog.
Commits on Nov 14, 2011
  1. Return NULL instead of throwing error when desired bound is not avail…

    tglsfdc committed Nov 14, 2011
    …able.
    
    Change range_lower and range_upper to return NULL rather than throwing an
    error when the input range is empty or the relevant bound is infinite.  Per
    discussion, throwing an error seems likely to be unduly hard to work with.
    Also, this is more consistent with the behavior of the constructors, which
    treat NULL as meaning an infinite bound.
  2. Return FALSE instead of throwing error for comparisons with empty ran…

    tglsfdc committed Nov 14, 2011
    …ges.
    
    Change range_before, range_after, range_adjacent to return false rather
    than throwing an error when one or both input ranges are empty.
    
    The original definition is unnecessarily difficult to use, and also can
    result in undesirable planner failures since the planner could try to
    compare an empty range to something else while deriving statistical
    estimates.  (This was, in fact, the cause of repeatable regression test
    failures on buildfarm member jaguar, as well as intermittent failures
    elsewhere.)
    
    Also tweak rangetypes regression test to not drop all the objects it
    creates, so that the final state of the regression database contains
    some rangetype objects for pg_dump testing.