Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evil-surround's :keywords contains its mailing list information #4087

Closed
mineo opened this issue Jul 31, 2016 · 4 comments
Closed

evil-surround's :keywords contains its mailing list information #4087

mineo opened this issue Jul 31, 2016 · 4 comments
Labels
sysadmin

Comments

@mineo
Copy link
Contributor

mineo commented Jul 31, 2016

At the moment, the entry for evil-surround in archive-contents looks like this (newlines inserted by me):

(evil-surround . [
(20160501 1704) 
(
(evil 
(1 2 12))) "emulate surround.vim from Vim" single 
(
(:keywords "emulation" "vi" "evil mailing list: <implementations-list at lists.ourproject.org> subscribe: http://tinyurl.com/implementations-list newsgroup: nntp://news.gmane.org/gmane.emacs.vim-emulation archives: http://dir.gmane.org/gmane.emacs.vim-emulation"))])

The Keywords declaration in evil-surround.el can be found here.

lm-keywords-list on evil-surround.el however returns the correct entries on Emacs 24.5.1. I had a quick look at the history of lisp-mnt.el and it looks like emacs-mirror/emacs@ee3c0ae / https://debbugs.gnu.org/cgi/bugreport.cgi?bug=13207 should have fixed situations like this.
@milkypostman
Copy link
Member

so basically we're just running too old a version of emacs?

@mineo
Copy link
Contributor Author

mineo commented Aug 1, 2016

I've downloaded https://github.com/emacs-mirror/emacs/blob/f4d79bd021831eb64e1bfc7f5c5b1ddb2138b37a/lisp/emacs-lisp/lisp-mnt.el (the version just before 13207 was fixed), eval-buffered it and now lm-keywords-list returns the list with the mailing list information included, so I guess that yes, an old version of Emacs really is the problem.

@purcell purcell mentioned this issue Aug 8, 2016
Closed
@purcell purcell added sysadmin and removed website labels Aug 17, 2016
mineo added a commit to mineo/evil-surround that referenced this issue Sep 3, 2016
@mineo
Move the Keywords after the Mailing list header
0a61b55 
At the moment, MELPA's archive-contents contains the mailing list
information in the keywords because they're using an older version of
Emacs for building archive-contents.

I have verified that this does not break the Package-Requires header.

This bug has been fixed in Emacs in
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=13207.

The issue for MELPA is melpa/melpa#4087.
@tarsius
Copy link
Member

tarsius commented Oct 4, 2017

@milkypostman Has Emacs been updated since?

@tarsius
Copy link
Member

tarsius commented Oct 4, 2017

Closing in favor of #4113.

@tarsius tarsius closed this as completed Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sysadmin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@purcell @tarsius @milkypostman @mineo