Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for tldr.el #3465

Merged
merged 1 commit into from Jan 6, 2016
Merged

Add recipe for tldr.el #3465

merged 1 commit into from Jan 6, 2016

Conversation

kuanyui
Copy link
Contributor

@kuanyui kuanyui commented Jan 5, 2016

@milkypostman
Copy link
Member

hey cool thing. here are comments,

  • needs an ;;;###autoload line above tldr function.
  • defvar should really be defcustom so that these things can be customizable.
  • do you need lexical binding for this? i think we are still suggesting that if you don't need it that you don't use it.
  • thanks for adding the emacs dependency. Is there a reason to require such a new version of emacs? I don't have an issue I was just curious.

@kuanyui
Copy link
Contributor Author

kuanyui commented Jan 6, 2016

hey cool thing. here are comments,

Thank you for your comments because I still don't know a lot of things in Emacs Lisp.

needs an ;;;###autoload line above tldr function.

Now @syohex push a PR to fix it.

defvar should really be defcustom so that these things can be customizable.

Ok, now fixed.

do you need lexical binding for this? i think we are still suggesting that if you don't need it that you don't use it.

(require 'autoinsert)
(auto-insert-mode t)

Emacs built-in auto-insert-mode insert that when I create a new *.el file.

thanks for adding the emacs dependency. Is there a reason to require such a new version of emacs? I don't have an issue I was just curious.

Because I have no elder Emacs version on my system to test...

@kuanyui kuanyui closed this Jan 6, 2016
@kuanyui kuanyui reopened this Jan 6, 2016
@syohex
Copy link
Contributor

syohex commented Jan 6, 2016

thanks for adding the emacs dependency. Is there a reason to require such a new version of emacs? I don't have an issue I was just curious.

with-temp-buffer-window was introduced at Emacs 24.3. And I confirmed tldr.el works on Emacs 24.3. I updated minimum Emacs version to 24.3 at kuanyui/tldr.el#1

@milkypostman
Copy link
Member

OK Cool, thanks 👍

milkypostman added a commit that referenced this pull request Jan 6, 2016
@milkypostman milkypostman merged commit 45af2c5 into melpa:master Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants