Created javascript web labels for LibreJS. #3753

Merged
merged 1 commit into from Apr 19, 2016

Projects

None yet

4 participants

@aplaice
Contributor
aplaice commented Apr 7, 2016

Web labels for:
mithril.js
moment.js
lodash.js
cookies.js
melpa.js

The added break tag in the footer is ugly html, so it might be necessary to change the structure/formatting.

@mattiasb mattiasb commented on an outdated diff Apr 7, 2016
html/jslicense
+ <td><a href="http://www.jclark.com/xml/copying.txt">Expat</a></td>
+ <td><a href="//cdnjs.cloudflare.com/ajax/libs/mithril/0.2.0/mithril.js">mithril.js</a></td>
+ </tr>
+ <tr>
+ <td><a href="//cdnjs.cloudflare.com/ajax/libs/moment.js/2.8.4/moment.min.js">moment.min.js</a></td>
+ <td><a href="http://www.jclark.com/xml/copying.txt">Expat</a></td>
+ <td><a href="//cdnjs.cloudflare.com/ajax/libs/moment.js/2.8.4/moment.js">moment.js</a></td>
+ </tr>
+ <tr>
+ <td><a href="//cdnjs.cloudflare.com/ajax/libs/lodash.js/2.4.1/lodash.min.js">lodash.min.js</a></td>
+ <td><a href="http://www.jclark.com/xml/copying.txt">Expat</a></td>
+ <td><a href="//cdnjs.cloudflare.com/ajax/libs/lodash.js/2.4.1/lodash.js">lodash.js</a></td>
+ </tr>
+ <tr>
+ <td><a href="//cdnjs.cloudflare.com/ajax/libs/Cookies.js/1.1.0/cookies.min.js">cookies.min.js</a></td>
+ <td><a href="http://www.jclark.com/xml/copying.txt">Unlicense</a></td>
@mattiasb
mattiasb Apr 7, 2016 Contributor

Should this link to Unlicense instead?

@aplaice
Contributor
aplaice commented Apr 7, 2016

Oops! Yes, it should.
I'll fix it.

@aplaice
Contributor
aplaice commented Apr 7, 2016

Unfortunately, it seems that
a) LibreJS parses only the URL in the table, ignoring the actual contents (e.g. the name of the license)
b) The Unlicense (or more precisely the link to the license) is not recognised by LibreJS as "approved" and indeed it's not mentioned at: http://www.gnu.org/licenses/javascript-labels.html.

This means that the "javascript web labels" solution currently won't be able to work (at least it does not work in my test)...

@artlogic
artlogic commented Apr 7, 2016

I've asked about unlicense here: http://lists.gnu.org/archive/html/help-librejs/2016-04/msg00000.html

I'm hoping there's a response soon.

@artlogic
artlogic commented Apr 7, 2016

I can confirm that this works on my system (except for the unrecognized license). However, I would suggest changing jslicense to jslicense.html so MIME types can be detected properly.

@purcell
Member
purcell commented Apr 13, 2016

Sorry, this one passed me by. Ready to be merged? Looks good to me.

@aplaice aplaice Created javascript web labels.
Web labels for:
mithril.js
moment.js
lodash.js
cookies.js
melpa.js
94bc3d6
@artlogic

@purcell - it looks like @aplaice has put in a request (separate from my own) to get unlicense added to librejs: http://lists.gnu.org/archive/html/bug-librejs/2016-04/msg00000.html

It looks like we're still waiting on the librejs folks to respond to either of our requests. It's only been a few days since @aplaice's request, so we may want to give it a bit more time.

Because unlicense is currently unrecognized, this pull request doesn't fix the problem. It does get us closer. I'd still suggest changing jslicense to jslicense.html so MIME types can be detected properly.

@aplaice
Contributor
aplaice commented Apr 13, 2016

Basically the situation is exactly as described by @artlogic — since LibreJS still does not seem to recognise the Unlicense, implementing these changes to MELPA's website wouldn't benefit anyone, in any way. (In this case, none of the alternative methods of labelling "free" javascript would work either, unless and until LibreJS starts recognising the Unlicense.)

Regarding jslicense.html, I've already changed the name of the file and the link to it, as you (@artlogic) suggested.

@purcell
Member
purcell commented Apr 13, 2016

Awesome, thanks -- I'll hold off on merging until you give me the go-ahead. :-) Really appreciate the time you've spent on this.

@artlogic

@purcell I'm thinking it might be best to merge this patch and update the website. At that point it will be up to LibreJS to add Unlicense, and it will be clear we're waiting on them.

@purcell purcell merged commit c2745e3 into melpa:master Apr 19, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@purcell
Member
purcell commented Apr 19, 2016

Done, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment