adding `buffer-manage` recipe #4489

Merged
merged 3 commits into from Jan 12, 2017

Projects

None yet

3 participants

@plandes
Contributor
plandes commented Jan 5, 2017 edited

Brief summary of what the package does

Provides support to multiple managed buffers (i.e. inferior shells, SQL sessions, etc.).

Direct link to the package repository

https://github.com/plandes/buffer-manage

Your association with the package

Original author and maintainer.

Relevant communications with the upstream package maintainer

This is the second submission, this time from a topic branch created from an earlier commit before the merges (sorry for any extra work that created!). Thanks again.

Checklist

  • I've read CONTRIBUTING.md
  • I've used package-lint to check for packaging issues, and addressed its feedback
  • I've built and installed the package using the instructions in the README
@syohex syohex referenced this pull request Jan 6, 2017
Closed

adding buffer-manage recipe #4482

3 of 3 tasks complete
@syohex syohex added the recipes label Jan 6, 2017
@syohex
Collaborator
syohex commented Jan 6, 2017

This package requires Emacs 24 or higher versions. However there are some warnings at loading on Emacs 24.3 or lower versions. Is this no problem ? And there are some byte-compile warnings too.

buffer-manage.el:Warning: `(entries (slot-value this (quote entries)))' is a
    malformed function
buffer-manage.el:Warning: `(last-switched-to (slot-value this (quote
    last-switched-to)))' is a malformed function
buffer-manage.el:Warning: `(entries (slot-value this (quote entries)))' is a
    malformed function
buffer-manage.el:Warning: `(last-switched-to (slot-value this (quote
    last-switched-to)))' is a malformed function
buffer-manage.el:Warning: `(include-frame-wins (slot-value this (quote
    include-frame-wins)))' is a malformed function
buffer-manage.el:Warning: `(read-history (slot-value this (quote
    read-history)))' is a malformed function
buffer-manage.el:Warning: `(entries (slot-value this (quote entries)))' is a
    malformed function
buffer-manage.el:Warning: `(last-switched-to (slot-value this (quote
    last-switched-to)))' is a malformed function
buffer-manage.el:Warning: `(entries (slot-value this (quote entries)))' is a
    malformed function
buffer-manage.el:Warning: `(last-switched-to (slot-value this (quote
    last-switched-to)))' is a malformed function
buffer-manage.el:Warning: `(include-frame-wins (slot-value this (quote
    include-frame-wins)))' is a malformed function
buffer-manage.el:Warning: `(read-history (slot-value this (quote
    read-history)))' is a malformed function
@plandes
Contributor
plandes commented Jan 6, 2017

It uses eieio heavily, which has changed a lot across 24 versions. I am on 24.5 and have no problem fixing it to that. In that case how do I enforce that?

Bonus question: What debian packages do I use to load 24.5? I have another package that is failing on a Travis build because it's using an early version of 24 (I think 24.0). Any ideas?

Thanks!

@plandes
Contributor
plandes commented Jan 6, 2017

Disregard the last comment.

I have moved the build to be more like the MELPA build and I am no longer getting the warnings on my travis build. Also I have committed a new change on my MELPA forked repo as the location of the lisp files has changed to the root. Let me know if I need to need to create a new pull request for that.

recipes/buffer-manage
@@ -0,0 +1 @@
+(buffer-manage :fetcher github :repo "plandes/buffer-manage" :files ("*.el"))
@syohex
syohex Jan 7, 2017 Collaborator

It is not necessary to specify :files attribute because it is enough to use default value. Please see https://github.com/melpa/melpa#recipe-format

@tarsius
Member
tarsius commented Jan 7, 2017

I have moved the build to be more like the MELPA build and I am no longer getting the warnings on my travis build.

Those that mean that this package now works on all 24 versions or that you now use 24.5 for testing on Travis? IMHO it would be fine to depend on >=24.5 and be done with it.

@plandes
Contributor
plandes commented Jan 7, 2017

@tarsius Thank for the input and I agree--we'll all be (or already moving) to 25 anyway. I have made 24.5 the dependency in the elisp file and the travis build and everything checks out. I have also made a bug fix.

@syohex Thanks for making me aware of that compliance detail. That change has been made and pushed to my melpa fork.

It appears ready to ship.

Thanks all!

@tarsius
Member
tarsius commented Jan 7, 2017

You might even want to depend on 25! eieio has again changed considerably in that release. I wasn't aware that it changed much during the 24 period, but from 24.* to 25 it changed a lot, and for the better.

@plandes
Contributor
plandes commented Jan 7, 2017

@tarsius Good point! I will do that but after I move to 25 myself :) I'll be moving to 25 soon and then go back and get everything 25 ready.

@plandes plandes closed this Jan 8, 2017
@plandes plandes reopened this Jan 8, 2017
@plandes
Contributor
plandes commented Jan 8, 2017 edited

@syohex There was one last change I committed. However, everything should check out. Let me know if there are any other changes you want to make.

@plandes
Contributor
plandes commented Jan 9, 2017 edited

@syohex @tarsius:

Will someone please tell me if there is something else I need to do to get this merged?

Do you want me to move to Emacs 25 or just be more patient :)

@tarsius tarsius self-assigned this Jan 9, 2017
@plandes plandes closed this Jan 9, 2017
@plandes plandes reopened this Jan 9, 2017
@plandes
Contributor
plandes commented Jan 9, 2017

I have updated this Emacs 25

@syohex syohex merged commit 28f8f37 into melpa:master Jan 12, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@syohex
Collaborator
syohex commented Jan 12, 2017

Merged

@plandes
Contributor
plandes commented Jan 13, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment