New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update perl6-mode repo location #4984

Merged
merged 2 commits into from Oct 4, 2017

Conversation

Projects
None yet
3 participants
@zakame
Contributor

zakame commented Sep 5, 2017

Per perl6/perl6-mode#11 and hinrik/perl6-mode#20 perl6-mode will now be maintained by the Perl6 community, and so needs an update on MELPA to
use the new location.

Many thanks to @treyharris for initiating the move (perl6/perl6-mode#9,) and to @hinrik for creating this major mode! 馃帀

Update perl6-mode repo location
Per perl6/perl6-mode#11 and
hinrik/perl6-mode#20 perl6-mode will now be
maintained by the Perl6 community, and so needs an update on MELPA to
use the new location.

Many thanks to @treyharris for initiating the
move (perl6/perl6-mode#9,) and to @hinrik for
creating this major mode! 馃帀
@purcell

This comment has been minimized.

Member

purcell commented Sep 6, 2017

Thanks! This should be straightforward, but the repo contents are not the same shape, since the new location has nqp-mode.el, which would also get bundled into the package. That file isn't obviously related, has a different name prefix, and invalid headers - what's the plan there? From my point of view it looks like it should be deleted.

@zakame

This comment has been minimized.

Contributor

zakame commented Sep 6, 2017

Thanks @purcell ! @tbrowder might know more about nqp-mode.el as he added that in, though a casual check for diffs with perl6-mode.el suggests no changes, so we could probably remove it or spin it off to another repo.

@tbrowder

This comment has been minimized.

tbrowder commented Sep 22, 2017

@zakame, I believe the nqp mode should stay since it is so closely related to Perl 6. Making it a separate repo would, I think, create more maintenance problems. Also, a typical Perl 6 dev will be diving into both Perl 6 and nqp code often at the same time. Dividing the two might make sense for elisp experts, but I have not seen many around here.

@zakame

This comment has been minimized.

Contributor

zakame commented Sep 22, 2017

Thanks @tbrowder.

I think the current concern though is that nqp-mode is exactly the same as perl6-mode (as a diff -Naur would show,) so perhaps make one a derivative mode of the other, say, perl6-mode derives or is a superset of nqp-mode, via define-derived-mode macro; I don't have problems bundling both modes in as long as there's no duplicates.

@purcell for context, nqp-mode aims to provide support for Not Quite Perl, a Perl 6-like environment used in VMs such as the Rakudo Perl6 compiler to further implement Perl 6.

@zakame zakame referenced this pull request Sep 22, 2017

Open

What to do with nqp-mode? #16

@tbrowder

This comment has been minimized.

tbrowder commented Sep 22, 2017

@purcell

This comment has been minimized.

Member

purcell commented Oct 4, 2017

Yep, I've no big problem with including nqp-mode in this package, in theory, but in its current form that file will mess things up when package.el generates autoloads for all the files in the package: it says, for example, that perl6-mode can be autoloaded from nqp-mode.el.

So if you wanted to include that file, all of its identifiers and headers should be updated so that they are named nqp-* rather than perl6-*. The alternative is that we simply exclude that file from the recipe. In fact, I'll just do that now in addition to merging this PR.

@purcell purcell merged commit ccdf359 into melpa:master Oct 4, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@zakame

This comment has been minimized.

Contributor

zakame commented Oct 4, 2017

Thanks @purcell @tbrowder !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment