Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a recipe for Elbank #5157

Merged
merged 1 commit into from Jan 22, 2018
Merged

Add a recipe for Elbank #5157

merged 1 commit into from Jan 22, 2018

Conversation

@NicolasPetton
Copy link
Contributor

NicolasPetton commented Nov 29, 2017

Brief summary of what the package does

Elbank is a personal finances reporting tool for Emacs. It uses
Weboob for scraping data from bank websites.n

Direct link to the package repository

https://github.com/NicolasPetton/Elbank

Your association with the package

I am the maintainer of the package.

Relevant communications with the upstream package maintainer

None needed

Checklist

Please confirm with x:

@purcell
Copy link
Member

purcell commented Dec 3, 2017

Thanks! This is a cool package. Here you should define the backwards-compatibility function with a prefix, according to the elisp conventions.

@NicolasPetton
Copy link
Contributor Author

NicolasPetton commented Dec 3, 2017

Thanks @purcell for the review, I've added a prefix: NicolasPetton/elbank@ae3aecb

@NicolasPetton
Copy link
Contributor Author

NicolasPetton commented Dec 15, 2017

@purcell Please do not merge it yet, I'm thinking about adding it to ELPA.

@tarsius
Copy link
Member

tarsius commented Jan 17, 2018

@NicolasPetton How's that progressing?

@purcell
Copy link
Member

purcell commented Jan 22, 2018

Please do not merge it yet, I'm thinking about adding it to ELPA.

@NicolasPetton Just FYI, I'm happy to merge this now and remove it later if you decide to distribute via ELPA.

@NicolasPetton
Copy link
Contributor Author

NicolasPetton commented Jan 22, 2018

@purcell You can merge it.

Elbank uses Weboob, which can connect to PayPal using non-free JavaScript from paypal.com, so until that issue is resolved, Elbank will not be be distributed through ELPA.

@purcell purcell merged commit 05d252e into melpa:master Jan 22, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@purcell
Copy link
Member

purcell commented Jan 22, 2018

Great, done.

Ambrevar added a commit to Ambrevar/melpa that referenced this pull request Feb 13, 2018
waymondo added a commit to waymondo/melpa that referenced this pull request Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.