Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isolate recipe #5653

Merged
merged 1 commit into from Aug 30, 2018
Merged

Add isolate recipe #5653

merged 1 commit into from Aug 30, 2018

Conversation

casouri
Copy link
Contributor

@casouri casouri commented Jul 29, 2018

Brief summary of what the package does

This is a surrouding tool.
It features powerful and easy customization system.
You can create complex regexp rules easily.

Direct link to the package repository

https://github.com/casouri/isolate

Your association with the package

Author

Relevant communications with the upstream package maintainer

None needed

Checklist

Please confirm with x:

@akirak
Copy link
Contributor

akirak commented Jul 30, 2018

This looks cool. I am a former vim user, and I have wanted an equivalent to surround without evil. This package may fill in the need.

@casouri
Copy link
Contributor Author

casouri commented Jul 30, 2018

Talking about surround without evil, there is embrace:

https://github.com/cute-jumper/embrace.el

Althought I’ll quietly say that mine is better.

@purcell
Copy link
Member

purcell commented Aug 30, 2018

Thanks, and sorry for the delay. Quick notes:

  • "flexable" should be "flexible", "surrouding" should be "surrounding". (Maybe try flyspell-prog-mode?)
  • Why not write isolate--append and isolate--push as defsubst instead of macros? Your macros expand their arguments multiple times, which could lead to multiple evaluation - read the macros section of Practical Common Lisp (free online) to understand what I mean.

In any case, I'll merge this now, but you should address the above points separately.

@purcell purcell merged commit c8091f8 into melpa:master Aug 30, 2018
@casouri
Copy link
Contributor Author

casouri commented Aug 30, 2018

Thanks! I'll fix those issues. I just got my flyspell back to work again recently... I will scan for any other typos.

casouri added a commit to casouri/isolate that referenced this pull request Aug 30, 2018
@casouri
Copy link
Contributor Author

casouri commented Aug 30, 2018

Fixed.

Xaldew pushed a commit to Xaldew/mymelpa that referenced this pull request Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants