Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for org-present-remote #5658

Merged
merged 1 commit into from Oct 9, 2018

Conversation

@duncan-bayne
Copy link
Contributor

@duncan-bayne duncan-bayne commented Jul 30, 2018

Brief summary of what the package does

Provides a web-based remote control for org-present.

Direct link to the package repository

https://gitlab.com/duncan-bayne/org-present-remote

Your association with the package

I am the author and maintainer.

Relevant communications with the upstream package maintainer

None needed.

Checklist

Please confirm with x:

@alphapapa
Copy link
Contributor

@alphapapa alphapapa commented Aug 1, 2018

This looks neat. A screenshot would be nice. :)

BTW, curious, is org-present-remote--trim-string necessary? Does string-trim not do the job?

Loading

@duncan-bayne
Copy link
Contributor Author

@duncan-bayne duncan-bayne commented Aug 1, 2018

@alphapapa Actually, org-present-remote--trim-string wasn't even used 😊 I've removed it upstream.

Screenshot below (actual screenshot, rendered onto a mobile device for context):

mobile-screenshot

Loading

@alphapapa
Copy link
Contributor

@alphapapa alphapapa commented Aug 1, 2018

LOL, I like the "screenshot". :)

Loading

@duncan-bayne
Copy link
Contributor Author

@duncan-bayne duncan-bayne commented Aug 2, 2018

User seeing mobile screenshot: meh

User seeing mobile screenshot rendered onto device: I COULD BE USING THAT RIGHT NOW, IN MY HAND, TAKE MY MONEY

:)

Loading

@duncan-bayne
Copy link
Contributor Author

@duncan-bayne duncan-bayne commented Aug 12, 2018

Any other changes you'd like before this is considered okay to merge?

Loading

@alphapapa
Copy link
Contributor

@alphapapa alphapapa commented Aug 12, 2018

Loading

@duncan-bayne
Copy link
Contributor Author

@duncan-bayne duncan-bayne commented Aug 12, 2018

@alphapapa Ah okay, thanks for letting me know :) I'll wait for feedback from the maintainers then.

Loading

@purcell
Copy link
Member

@purcell purcell commented Aug 30, 2018

Thanks, and sorry for the delay. Looks good, but the header is malformatted: you've included the metadata headers in the Commentary text. Instead, please stick to the standard header boilerplate layout: to see what that is, try creating an empty .el file and then calling M-x auto-insert.

Loading

@duncan-bayne
Copy link
Contributor Author

@duncan-bayne duncan-bayne commented Sep 4, 2018

@purcell Thanks, I've fixed that upstream (https://gitlab.com/duncan-bayne/org-present-remote/commit/daebc08c52a599b1bcbdc4e80b1a212a3463fa2b). You might be interested to know that M-x auto-insert didn't work on an empty Emacs Lisp buffer; I had to specifically visit a file in order for it to work. Slightly confusing.

Loading

@purcell
Copy link
Member

@purcell purcell commented Sep 29, 2018

The header is the right shape now, thanks, but you've lost the necessary ;; Package-Requires: header. If you ping us here once it's added back in, any of us can go ahead and merge this.

Loading

@duncan-bayne
Copy link
Contributor Author

@duncan-bayne duncan-bayne commented Oct 1, 2018

@purcell Fixed upstream (and re-linted).

Loading

@DamienCassou DamienCassou force-pushed the org-present-remote branch from 915b899 to fe77aa6 Oct 9, 2018
@DamienCassou
Copy link
Collaborator

@DamienCassou DamienCassou commented Oct 9, 2018

If we were using GitLab, I would press the blue button

https://petton.fr/nextcloud/index.php/apps/gallery/s/HwGg5etp6PPQRXC/download

Loading

@DamienCassou DamienCassou merged commit 66b0920 into melpa:master Oct 9, 2018
1 check passed
Loading
tarsius pushed a commit to emacsmirror/org-present-remote that referenced this issue Oct 14, 2018
Received feedback[1] that the header is malformed.  Regenerated with
M-x auto-insert, and customised.

[1] melpa/melpa#5658 (comment)
tarsius pushed a commit to emacsmirror/org-present-remote that referenced this issue Oct 14, 2018
Addresses further feedback on MELPA PR[1].

[1] melpa/melpa#5658 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants