New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add highlight-doxygen #5709

Merged
merged 1 commit into from Aug 30, 2018

Conversation

Projects
None yet
2 participants
@Lindydancer
Contributor

Lindydancer commented Aug 29, 2018

Brief summary of what the package does

Highlight Doxygen comments.

In addition to highlighting Doxygen commands and their arguments, the entire comment is highlighted as a block. In addition, code blocks inside Doxygen comments are highlighted as code, according to the language they written in.

Direct link to the package repository

https://github.com/Lindydancer/highlight-doxygen

Your association with the package

I'm the author.

Relevant communications with the upstream package maintainer

None needed

Checklist

Please confirm with x:

@purcell

This comment has been minimized.

Show comment
Hide comment
@purcell

purcell Aug 30, 2018

Member

Thanks! I feel like all the packages you submit are very well organised and straightforward to review and merge, which makes me happy. :-)

This is no exception, and my only note is that the combination of :inherit font-lock-doc-face and :background "grey95" etc. is likely to lead to ugly results by default with many themes. I wonder if there's a more robust alternative. Anyhow, I'll go ahead and merge now.

Member

purcell commented Aug 30, 2018

Thanks! I feel like all the packages you submit are very well organised and straightforward to review and merge, which makes me happy. :-)

This is no exception, and my only note is that the combination of :inherit font-lock-doc-face and :background "grey95" etc. is likely to lead to ugly results by default with many themes. I wonder if there's a more robust alternative. Anyhow, I'll go ahead and merge now.

@purcell purcell merged commit 0153353 into melpa:master Aug 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Lindydancer

This comment has been minimized.

Show comment
Hide comment
@Lindydancer

Lindydancer Aug 30, 2018

Contributor
Contributor

Lindydancer commented Aug 30, 2018

@purcell

This comment has been minimized.

Show comment
Hide comment
@purcell

purcell Aug 30, 2018

Member

I've tested this on a handful of themes, and it looked good in all of them. Of course, should there be a theme where it doesn't look good, the faces my package provide can be customized to match the theme.

Yup, agree, I don't think there's a perfect solution. :-)

Member

purcell commented Aug 30, 2018

I've tested this on a handful of themes, and it looked good in all of them. Of course, should there be a theme where it doesn't look good, the faces my package provide can be customized to match the theme.

Yup, agree, I don't think there's a perfect solution. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment