Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe `helm-esa` #6186

Merged
merged 1 commit into from Jun 9, 2019

Conversation

Projects
None yet
3 participants
@masutaka
Copy link
Contributor

commented May 26, 2019

Brief summary of what the package does

helm-esa.el is a helm interface for esa which is a document share service.

Direct link to the package repository

https://github.com/masutaka/emacs-helm-esa

Your association with the package

I am the author.

Relevant communications with the upstream package maintainer

None needed

Checklist

Please confirm with x:

  • The package is released under a GPL-Compatible Free Software License.

  • I've read CONTRIBUTING.org

  • I've used the latest version of package-lint to check for packaging issues, and addressed its feedback

  • My elisp byte-compiles cleanly

    $ emacs -Q -batch --eval '(package-initialize)' -f batch-byte-compile helm-esa.el
    $ echo $?
    0
    
  • M-x checkdoc is happy with my docstrings

  • I've built and installed the package using the instructions in CONTRIBUTING.org

  • I have confirmed some of these without doing them

@purcell

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

Looks great, but why does this require curl? The default URL facilities in emacs should be able to handle this case, right? Or one of the wrapper libraries like request. Relying on curl makes this library less portable between operating systems.

@masutaka

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

Thanks for your review.

I ported it from the following packages:

Then I did not think deeply about using curl.

I will avoid using curl. Should I fix this time?

@masutaka

This comment has been minimized.

Copy link
Contributor Author

commented Jun 9, 2019

I've removed curl from the requirements using request.el.

Could you review, please?
https://github.com/masutaka/emacs-helm-esa

@riscy

This comment has been minimized.

Copy link
Collaborator

commented Jun 9, 2019

Looks great!

@riscy riscy merged commit 5813ef3 into melpa:master Jun 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.