Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for eglot-jl #6531

Merged
merged 1 commit into from Dec 23, 2019
Merged

Add recipe for eglot-jl #6531

merged 1 commit into from Dec 23, 2019

Conversation

non-Jedi
Copy link
Contributor

@non-Jedi non-Jedi commented Nov 6, 2019

Brief summary of what the package does

Load support for the Julia language server into eglot.

Direct link to the package repository

https://github.com/non-Jedi/eglot-jl

Your association with the package

author

Relevant communications with the upstream package maintainer

None needed

Checklist

Please confirm with x:

  • The package is released under a GPL-Compatible Free Software License.
  • I've read CONTRIBUTING.org
  • I've used the latest version of package-lint to check for packaging issues, and addressed its feedback
  • My elisp byte-compiles cleanly
  • M-x checkdoc is happy with my docstrings
  • I've built and installed the package using the instructions in CONTRIBUTING.org
  • I have confirmed some of these without doing them

@alphapapa
Copy link
Contributor

alphapapa commented Nov 7, 2019

Is the LANGUAGEeglot naming a convention for eglot packages? If not, you might consider eglot-jl. jleglot looks kind of like j leglot to me. :)

@non-Jedi
Copy link
Contributor Author

non-Jedi commented Nov 7, 2019

Nah. There's no convention. Support for most languages is actually bundled with eglot, but there's a bit more going on with Julia, so it made sense with me to package it up separately. I think eglot-jl is reasonable, so I'll go ahead and change it.

@non-Jedi non-Jedi changed the title Add recipe for jleglot Add recipe for eglot-jl Nov 7, 2019
@riscy
Copy link
Member

riscy commented Dec 23, 2019

Sorry for the long wait on this one -- this looks great!

@riscy riscy merged commit 5f04bf5 into melpa:master Dec 23, 2019
@tarsius
Copy link
Member

tarsius commented Dec 26, 2019

@non-Jedi Is it very important to you to say this and nothing else?:

;;; License:

;; To the extent possible under law, Adam Beckmeyer has waived all
;; copyright and related or neighboring rights to eglot-jl. This
;; work is published from: United States.

Or would you be willing to add a header keyword

;; License: public-domain

Do the above things mean different things to you? If so, is the latter a good enough approximation?


Melpa is supposed to only contain packages that are released under terms that are compatible with version 3 of the GPL. "public-domain" is compatible as far as I know, while I have no idea if that is also the case for the words you have used.


@riscy Please look into license issues before merging.

@riscy
Copy link
Member

riscy commented Dec 26, 2019

Please look into license issues before merging.

Ah, thanks! I'll start checking more closely

@riscy
Copy link
Member

riscy commented Dec 30, 2019

Just since there's no update visible here, I see the repo is CC0 licensed now.

@tarsius
Copy link
Member

tarsius commented Dec 31, 2019

Unfortunately https://github.com/licensee/licensee is not able to detect that license.

@non-Jedi Please add this to your library:

;; License: CC0

Thank you.


Maybe you could incorporate elx-license from elx into your workflow?

@non-Jedi
Copy link
Contributor Author

Odd that it's not picked up: https://github.com/licensee/licensee/blob/master/vendor/choosealicense.com/_licenses/cc0-1.0.txt

Will modify header and look at elx-license.

Thanks

non-Jedi added a commit to non-Jedi/eglot-jl that referenced this pull request Jan 2, 2020
@tarsius
Copy link
Member

tarsius commented Jan 6, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants