Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix IE7 and IE8 compatibility #50

Merged
merged 1 commit into from Jan 9, 2013

Conversation

Projects
None yet
2 participants

Commit 971a881 introduced a regression on Internet Explorer 7 & 8.

The Object.keys is not implemented on these browsers as described here: https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/Object/keys

I replaced this ECMAScript 5th Edition function by a more classic style. It's been tested on Internet Explorer.

Both Coffeescript & Javascript files have been modified, no need to compile.

@meltingice meltingice added a commit that referenced this pull request Jan 9, 2013

@meltingice meltingice Merge pull request #50 from michaelperrin/fix/ie8-compatibility
Fix IE7 and IE8 compatibility
de37a51

@meltingice meltingice merged commit de37a51 into meltingice:master Jan 9, 2013

Owner

meltingice commented Jan 9, 2013

Looks great, thanks!

Thanks for merging so fast!

@michaelperrin michaelperrin pushed a commit to michaelperrin/ajax-chosen that referenced this pull request Jul 24, 2013

@meltingice meltingice Merge pull request #50 from michaelperrin/fix/ie8-compatibility
Fix IE7 and IE8 compatibility
92e194c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment