Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Tweaks #55

Merged
merged 5 commits into from Mar 10, 2013

Conversation

Projects
None yet
2 participants
Contributor

fredwu commented Feb 8, 2013

A couple of tweaks:

  • Fixed the broken default callback argument.
  • Fixed the default value for chosenOptions.
  • Fixed the bug where the success callback is called multiple times.
  • Have field passed into the callback function as it's very useful.
  • Simplified the JS by getting rid the usage of if not.

This PR contains the fix to #30 (which is covered by PR #51).

Contributor

fredwu commented Feb 8, 2013

This PR also removes the excessive amount of whitespaces in the coffee source. But for the benefit of diffing, you could view the changes without whitespaces here. :)

Contributor

fredwu commented Mar 9, 2013

Hi @meltingice, any chance to review this PR yet? :)

@meltingice meltingice added a commit that referenced this pull request Mar 10, 2013

@meltingice meltingice Merge pull request #55 from fredwu/tweaks
Tweaks
a7ff8fc

@meltingice meltingice merged commit a7ff8fc into meltingice:master Mar 10, 2013

@michaelperrin michaelperrin pushed a commit to michaelperrin/ajax-chosen that referenced this pull request Jul 24, 2013

@meltingice meltingice Merge pull request #55 from fredwu/tweaks
Tweaks
e800071
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment