Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show stack trace if verbose mode is enabled #39

Merged
merged 1 commit into from Feb 26, 2020

Conversation

@juneeighteen
Copy link
Contributor

juneeighteen commented Feb 26, 2020

In reference to Issue #34, this should help with the credential masking. This will only dump the stack trace if the user specifically requested the -v flag enabled.


This change is Reviewable

@jtheriault

This comment has been minimized.

Copy link
Contributor

jtheriault commented Feb 26, 2020

Simple and direct! Thank you very much for this!

Copy link
Contributor

jtheriault left a comment

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@jtheriault jtheriault merged commit 5859539 into meltwater:master Feb 26, 2020
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/drone/pr Build is failing
Details
code-review/reviewable 1 file reviewed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.