Permalink
Browse files

MB-7190: Add back store cmd timings

Change-Id: I060a3c30b0cc897729c66c1584e5fb396ce06264
Reviewed-on: http://review.couchbase.org/22570
Reviewed-by: Chiyoung Seo <chiyoung.seo@gmail.com>
Tested-by: Chiyoung Seo <chiyoung.seo@gmail.com>
  • Loading branch information...
1 parent a8db69f commit 9b8377b94356c867cab2f63b2b5798001ca671f7 @mikewied mikewied committed with Farshid Ghods Nov 15, 2012
Showing with 6 additions and 1 deletion.
  1. +0 −1 management/cbstats
  2. +2 −0 src/ep_engine.cc
  3. +4 −0 src/stats.hh
View
@@ -83,7 +83,6 @@ def time_label(s):
return "%d%s" % (s / factor, lbl)
def sec_label(s):
- print "sec_label(%d)" % s
return time_label(s * 1000000)
def size_label(s):
View
@@ -1452,6 +1452,7 @@ ENGINE_ERROR_CODE EventuallyPersistentEngine::store(const void *cookie,
ENGINE_STORE_OPERATION operation,
uint16_t vbucket)
{
+ BlockTimer timer(&stats.storeCmdHisto);
ENGINE_ERROR_CODE ret;
Item *it = static_cast<Item*>(itm);
item *i = NULL;
@@ -3172,6 +3173,7 @@ ENGINE_ERROR_CODE EventuallyPersistentEngine::doTimingStats(const void *cookie,
// Regular commands
add_casted_stat("get_cmd", stats.getCmdHisto, add_stat, cookie);
+ add_casted_stat("store_cmd", stats.storeCmdHisto, add_stat, cookie);
add_casted_stat("arith_cmd", stats.arithCmdHisto, add_stat, cookie);
add_casted_stat("get_stats_cmd", stats.getStatsCmdHisto, add_stat, cookie);
// Admin commands
View
@@ -302,6 +302,9 @@ public:
//! Histogram of get commands.
Histogram<hrtime_t> getCmdHisto;
+ //! Histogram of store commands.
+ Histogram<hrtime_t> storeCmdHisto;
+
//! Histogram of arithmetic commands.
Histogram<hrtime_t> arithCmdHisto;
@@ -403,6 +406,7 @@ public:
setVbucketCmdHisto.reset();
delVbucketCmdHisto.reset();
getCmdHisto.reset();
+ storeCmdHisto.reset();
arithCmdHisto.reset();
tapVbucketResetHisto.reset();
tapMutationHisto.reset();

0 comments on commit 9b8377b

Please sign in to comment.