Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Aug 28, 2015
  1. @abhinavdangeti

    Use RO instance of underlying store everywhere in warmup

    abhinavdangeti authored
    This is because only READER threads run all the warmup
    tasks.
    
    Change-Id: I0164751fcf67f9559d74d8408dc7ac7207633b14
    Reviewed-on: http://review.couchbase.org/54893
    Reviewed-by: Sriram Ganesan <sriram@couchbase.com>
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: Dave Rigby <daver@couchbase.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Commits on Aug 27, 2015
  1. @abhinavdangeti @chiyoung

    MB-15662: Correct accounting for compressed values on Producer

    abhinavdangeti authored chiyoung committed
    If value compression is enabled, then correctly account the
    the bytes_sent value of the buffer log, with the compressed value
    as opposed to the uncompressed value.
    
    Change-Id: I14b6d75d4bcb32b39c8b01c122a035d45c9ebd7f
    Reviewed-on: http://review.couchbase.org/54868
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: Dave Rigby <daver@couchbase.com>
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
  2. @mikewied @chiyoung

    Fix formatting in backfill complete log message (add space)

    mikewied authored chiyoung committed
    Change-Id: I4ef99f2864acbb5c954dc9293023ecac0ab068e1
    Reviewed-on: http://review.couchbase.org/54872
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
    Tested-by: Chiyoung Seo <chiyoung@couchbase.com>
  3. @mikewied @chiyoung

    Backfill task completion should be logged at NOTICE level

    mikewied authored chiyoung committed
    This message should be considered normal behavior and should not
    be logged at warning level.
    
    Change-Id: I2fdbd0434758e816dae5b1c1cd6198340e9879be
    Reviewed-on: http://review.couchbase.org/54871
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
  4. @abhinavdangeti @chiyoung

    MB-16160: Wait for flusher to check persisted seqno

    abhinavdangeti authored chiyoung committed
    As the Commit validation runs on slow disks (very),
    wait for the flusher to settle, before issuing the
    seqno persistence command, so that there wouldn't
    be a timeout.
    
    Change-Id: I00b64a2dc5fbddcaacb785fc9ea3d4ce4ced1bda
    Reviewed-on: http://review.couchbase.org/54869
    Reviewed-by: Sriram Ganesan <sriram@couchbase.com>
    Tested-by: abhinav dangeti <abhinav@couchbase.com>
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
Commits on Aug 25, 2015
  1. @chiyoung

    Call fdb_init() in ForestKVStore

    Sriram Ganesan authored chiyoung committed
    fdb_init() initializes the memory needed for the buffer cache.
    Also ensure that this memory that is allocated to the buffer
    cache isn't accounted in the per-bucket memory quota.
    
    Change-Id: I87a1432f518b43c9b91e58d7d2c52d13efbdc7e1
    Reviewed-on: http://review.couchbase.org/54745
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
  2. @manudhundi

    MB-13910: Add aggressive flow control policy

    manudhundi authored
    In this policy flow control buffer sizes are always set as percentage (5%) of
    bucket memory quota across all flow control buffers, but within max (50MB)
    and a min value (10 MB). Every time a new connection is made or a disconnect
    happens, flow control buffer size of all other connections is changed to
    share an aggregate percentage(5%) of bucket memory
    
    Change-Id: I0c6f103ebe00964195ad6f1c4d2ba79c41fd3db8
    Reviewed-on: http://review.couchbase.org/54240
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
    Tested-by: Manu Dhundi <manu@couchbase.com>
  3. @abhinavdangeti

    Merge remote-tracking branch 'couchbase/sherlock'

    abhinavdangeti authored
    couchbase/sherlock:
    * MB-16145: Move all backfills from pending to active when possible
    
    Change-Id: I69a6d6bee9f6d55064d9e7dc1bced9e7d6b5630d
  4. @abhinavdangeti

    Remove unused functionality from backfill-manager

    abhinavdangeti authored
    Functions:
    - wakeUpSnoozingBackfills
    - addIfLessThanMax
    
    Change-Id: I8832335916a35897959b85af527a1cf884605c22
    Reviewed-on: http://review.couchbase.org/54796
    Reviewed-by: Sundararaman Sridharan <sundar@couchbase.com>
    Tested-by: Sundararaman Sridharan <sundar@couchbase.com>
Commits on Aug 24, 2015
  1. @abhinavdangeti @chiyoung

    MB-16145: Move all backfills from pending to active when possible

    abhinavdangeti authored chiyoung committed
    Move all backfills from the pending queue to the active queue
    to ensure that some of the backfill tasks don't have to wait
    longer than they have to before they're processed.
    
    Change-Id: If79da6523162e5a88c532f3fc84fb1d6e07d476a
    Reviewed-on: http://review.couchbase.org/54797
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
  2. @abhinavdangeti

    Add stat information to doc/stats.org

    abhinavdangeti authored
    Context:
    - vbucket_persist_low_tasks
    - defragmenter_tasks
    - workload_monitor_tasks
    
    Change-Id: I6365cf2533af0818bb870766545f29aa0d9994a5
    Reviewed-on: http://review.couchbase.org/54795
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
    Tested-by: abhinav dangeti <abhinav@couchbase.com>
  3. @abhinavdangeti

    Refactor scheduler and runtimes' cbstats for backfill_tasks

    abhinavdangeti authored
    backfill_tasks_tasks --> backfill_tasks
    
    Change-Id: I1ab7fd5fac1a0fc9a03b92e4e84e85a131376ced
    Reviewed-on: http://review.couchbase.org/54792
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
    Tested-by: abhinav dangeti <abhinav@couchbase.com>
  4. @abhinavdangeti

    Failing to open/rename accesslog/stats.json isn't a show stopper

    abhinavdangeti authored
    We shouldn't log an error in renaming or opening an access log file
    or a stats.json file as something fatal, as all we do is remove the
    file and resume regular execution.
    
    Change-Id: If3cdfb0aa2a275c782e42f4ce13d08bca3a50a26
    Reviewed-on: http://review.couchbase.org/54787
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
    Tested-by: abhinav dangeti <abhinav@couchbase.com>
Commits on Aug 22, 2015
  1. @abhinavdangeti

    MB-15374: Cancel all tasks if force flag set during destroy

    abhinavdangeti authored
    Override the blockShutdown flag for tasks if force is set
    during shutdown/destroy.
    
    Change-Id: Ic95807a5d8781455a6d56c61ae053bda47dbf4de
    Reviewed-on: http://review.couchbase.org/54746
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
    Tested-by: buildbot <build@couchbase.com>
Commits on Aug 21, 2015
  1. @abhinavdangeti

    During init only let RW instances of kvstore to remove temp files

    abhinavdangeti authored
    Do not let RO instances of the couchkvstore even attempt to remove
    stale or temporary files during initialization. This would ensure
    that there's no spamming of the logs with this message upon warmup:
    
    "A read-only instance of the underlying store was not allowed to delete
    a temporary file:.."
    
    Change-Id: I027af9443ec14905608b1e1eab2d817f27b1de0f
    Reviewed-on: http://review.couchbase.org/54744
    Reviewed-by: Sriram Ganesan <sriram@couchbase.com>
    Tested-by: abhinav dangeti <abhinav@couchbase.com>
  2. @abhinavdangeti

    MB-13533: Adding an initial schedule time for expiry pager

    abhinavdangeti authored
    Initial schedule time by default is set to -1, meaning
    the expiry pager will sleep for the specified sleeptime
    upon initialization before running.
    
    exp_pager_initial_run_time (UTC) can be set during run
    time using cbepctl to a value in range (0, 23), which
    would schedule the expiry pager at that hour, and after
    that the expiry pager would run in an interval specified
    by exp_pager_stime.
    
    New stat expiry_pager_task_time will tell us the next
    task time for expiry pager in UTC.
    
    Change-Id: Iae50ab03d0093a898308e54c1228b6cc0058cae9
    Reviewed-on: http://review.couchbase.org/54524
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: Dave Rigby <daver@couchbase.com>
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
  3. @abhinavdangeti

    Use store variable to check if access scanner is enabled

    abhinavdangeti authored
    Use the store variable rather than from the configuration
    file to determine if access scanner is enabled, to reduce
    locking overhead.
    
    Change-Id: Ie149e16c9899fa3c6fe0a1292468a88e6501da34
    Reviewed-on: http://review.couchbase.org/54715
    Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
    Tested-by: abhinav dangeti <abhinav@couchbase.com>
Commits on Aug 20, 2015
  1. @abhinavdangeti

    Merge remote-tracking branch 'couchbase/sherlock'

    abhinavdangeti authored
    couchbase/sherlock:
    | *   727a5d8 Merge remote-tracking branch 'couchbase/3.0.x' into 'couchbase/sherlock'
    | |\
    | | * 4b5cdf9 MB-16042: Do not process invalid snapshot markers
    | | * 13ba876 [BP] MB-16045: Dcp Mutations/Deletions with seq number 0 are invalid
    | | * 46d6286 MB-16042: [BP] Handling erroneous DCP snapshot markers
    | | * b232153 [BP] MB-16044: Handling erroneous DCP mutations/deletions
    | | * 0b00cf9 MB-16131: [BP] Initialize last_seqno for a passive stream accurately
    | | * 03c849b MB-16125: Do not wait for certain tasks to shutdown
    
    Change-Id: I52d96b4e446f455c2c38441f18fe093376a14e07
  2. @abhinavdangeti

    Merge remote-tracking branch 'couchbase/3.0.x' into 'couchbase/sherlock'

    abhinavdangeti authored
    couchbase/3.0.x:
    * MB-16042: Do not process invalid snapshot markers
    * [BP] MB-16045: Dcp Mutations/Deletions with seq number 0 are invalid
    * MB-16042: [BP] Handling erroneous DCP snapshot markers
    * [BP] MB-16044: Handling erroneous DCP mutations/deletions
    * MB-16131: [BP] Initialize last_seqno for a passive stream accurately
    * MB-16125: Do not wait for certain tasks to shutdown
    
    Change-Id: Ib0ed086ab14d57c7007dd299efa56603343e76c3
  3. @abhinavdangeti

    MB-16042: Do not process invalid snapshot markers

    abhinavdangeti authored
    Snapshot markers with start > end, are to be
    considered as INVALID.
    
    Change-Id: Ibe1922dc388992b830cec7687e0010e5fd26e982
    Reviewed-on: http://review.couchbase.org/54712
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
  4. @abhinavdangeti

    [BP] MB-16045: Dcp Mutations/Deletions with seq number 0 are invalid

    abhinavdangeti authored
    If mutations or deletions are received at a DCP consumer whose
    sequence numbers are ZERO (malicious), they need to be dropped
    and the error code returned is to be EINVAL.
    
    Change-Id: I920bf969027fae912a5e86164d235d1110f7688b
    Reviewed-on: http://review.couchbase.org/54711
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
    Tested-by: buildbot <build@couchbase.com>
  5. @abhinavdangeti

    MB-16042: [BP] Handling erroneous DCP snapshot markers

    abhinavdangeti authored
    A snapshot marker whose start seqno and end seqno
    are both lesser than the last received mutation's
    sequence number then, we're better off dropping it.
    
    Change-Id: Ic33abae37eb164f212d4306f99c9029535dcb42c
    Reviewed-on: http://review.couchbase.org/54710
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
    Tested-by: buildbot <build@couchbase.com>
  6. @abhinavdangeti @chiyoung

    [BP] MB-16044: Handling erroneous DCP mutations/deletions

    abhinavdangeti authored chiyoung committed
    Adding some sanity-check code which ensures that
    erroneous mutations and deletions are dropped when
    sent in from an autonomous producer which could
    inject assertions otherwise.
    
    Change-Id: I48b68783314133e3cf3e1e5b77a61ee043e73115
    Reviewed-on: http://review.couchbase.org/54709
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
  7. @abhinavdangeti @chiyoung

    MB-16131: [BP] Initialize last_seqno for a passive stream accurately

    abhinavdangeti authored chiyoung committed
    last_seqno for a passive stream is to point to the
    vbucket high_seqno to ensure that erroneous packets
    are handled correctly when received at the consumer.
    
    Change-Id: I077ad5b2ca08c3d4bfb81237b46f259a60d3c4dc
    Reviewed-on: http://review.couchbase.org/54708
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
  8. @abhinavdangeti @chiyoung

    MB-16125: Do not wait for certain tasks to shutdown

    abhinavdangeti authored chiyoung committed
    - Access scanner
    - Vbucket compaction
    
    + Additional refactoring in tasks.h for a parameter
    to indicate its meaning - completeBeforeShutdown
    
    Change-Id: I68ac8364177733559926f0ee87acd3d2852e3585
    Reviewed-on: http://review.couchbase.org/54706
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: Dave Rigby <daver@couchbase.com>
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
  9. @daverigby @chiyoung

    ep_testsuite: Remove EP-ENGINE-TESTSUITE env var

    daverigby authored chiyoung committed
    Remove setting the environment variable 'EP-ENGINE-TESTSUITE' in
    ep_testsuite_common. This was causing tests to crash when run with
    code coverage, due to the memory passed to putenv() no longer being
    valid once the testsuite shared object had been unloaded.
    
    Given that there are no users of this environment variable at present,
    simply remove it.
    
    Change-Id: I978c3d9599b3bb96e400e62dd63e4e222c995b95
    Reviewed-on: http://review.couchbase.org/54582
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
  10. @abhinavdangeti

    Merge remote-tracking branch 'couchbase/sherlock'

    abhinavdangeti authored
    couchbase/sherlock:
    * Fix compilation warnings while printing variables in log messages
    * Fix incorrect arguments to log message in DcpConsumer
    * Merge remote-tracking branch 'couchbase/3.0.x' into 'couchbase/sherlock'
        - MB-15926: Do not add passive stream if tap consumer exists & vice-versa
    * MB-16045: Dcp Mutations/Deletions with seq number 0 are invalid
    * MB-16056: Remove unnecessary asserts in DCP
    * MB-16044: Handling erroneous DCP snapshot markers
    * MB-16044: Handling erroneous DCP mutations/deletions
    * Initialize last_seqno for a passive stream accurately
    
    Change-Id: Id81cc4dcbf52cdc223e8ccd1fca2e34f72e44d75
  11. @abhinavdangeti

    Fix compilation warnings while printing variables in log messages

    abhinavdangeti authored
    opaque --> uint32_t
    last_read_seqno --> uint64_t
    
    Change-Id: I1c5011b4ee6ff5efad2f6c55c4e8358257818e66
    Reviewed-on: http://review.couchbase.org/54610
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: Sriram Ganesan <sriram@couchbase.com>
  12. @abhinavdangeti

    Fix incorrect arguments to log message in DcpConsumer

    abhinavdangeti authored
    Change-Id: Ic90703caff388523d3acafd4a57195feb76b2d12
    Reviewed-on: http://review.couchbase.org/54609
    Reviewed-by: Sriram Ganesan <sriram@couchbase.com>
    Tested-by: buildbot <build@couchbase.com>
  13. @abhinavdangeti

    Merge remote-tracking branch 'couchbase/3.0.x' into 'couchbase/sherlock'

    abhinavdangeti authored
    couchbase/3.0.x:
    * MB-15926: Do not add passive stream if tap consumer exists & vice-versa
    
    Change-Id: I22cb175a7e7230f303a78b4386782b260c616128
  14. @abhinavdangeti

    MB-16045: Dcp Mutations/Deletions with seq number 0 are invalid

    abhinavdangeti authored
    If mutations or deletions are received at a DCP consumer whose
    sequence numbers are ZERO (malicious), they need to be dropped
    and the error code returned is to be EINVAL.
    
    Change-Id: I920bf969027fae912a5e86164d235d1110f7688b
    Reviewed-on: http://review.couchbase.org/54604
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
    Tested-by: buildbot <build@couchbase.com>
  15. @abhinavdangeti

    MB-15926: Do not add passive stream if tap consumer exists & vice-versa

    abhinavdangeti authored
    Do not allow the creation of a DCP passive stream for a vbucket
    even if a tap consumer is still connected. Similarly, do not allow
    the creation of a tap consumer if a DCP passive stream is still
    connected for the vbucket.
    
    Change-Id: Ie7ea059cb512ac550fece437a6526081a4ee3fdd
    Reviewed-on: http://review.couchbase.org/54556
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
    Reviewed-by: Sriram Ganesan <sriram@couchbase.com>
    Tested-by: buildbot <build@couchbase.com>
Commits on Aug 18, 2015
  1. @manudhundi

    MB-16056: Remove unnecessary asserts in DCP

    manudhundi authored
    Change-Id: Ifcacae87c6d025293087739ab4de995e7cb03bfd
    Reviewed-on: http://review.couchbase.org/54527
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
    Tested-by: Manu Dhundi <manu@couchbase.com>
Commits on Aug 17, 2015
  1. @daverigby @chiyoung

    Enable code coverage for ep-engine

    daverigby authored chiyoung committed
    Change-Id: I710c51d822695e8fdadeab0fcf5c02842bd93d92
    Reviewed-on: http://review.couchbase.org/54496
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: abhinav dangeti <abhinav@couchbase.com>
    Reviewed-by: Chiyoung Seo <chiyoung@couchbase.com>
  2. @abhinavdangeti

    MB-16044: Handling erroneous DCP snapshot markers

    abhinavdangeti authored
    A snapshot marker whose start seqno and end seqno
    are both lesser than the last received mutation's
    sequence number then, we're better off dropping it.
    
    Change-Id: Ic33abae37eb164f212d4306f99c9029535dcb42c
    Reviewed-on: http://review.couchbase.org/54454
    Reviewed-by: Dave Rigby <daver@couchbase.com>
    Tested-by: buildbot <build@couchbase.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Something went wrong with that request. Please try again.