Permalink
Commits on Oct 8, 2010
  1. handle nulls in stat samples

    Aliaksey Kandratsenka authored and seanlynch committed Oct 8, 2010
    After upgrading server on version which added new stat we can now
    serve 'null' for new stat values.
    
    Change-Id: Ia38fa37381c92817f0ae523f87f202526754c1d6
    Reviewed-on: http://review.northscale.com/3153
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Sean Lynch <seanl@literati.org>
  2. use forward-compatible format of stat samples. Bug 2718

    Aliaksey Kandratsenka authored and seanlynch committed Oct 8, 2010
    Old code used record to represent stat values sample which is not
    forward-compatible. It also conflicts with our goal of supporting
    rolling upgrades, because same format is used to communicate stats
    between nodes.
    
    A few notes:
    
    * we're using dict and not (even more forward-compatible) proplist
      because it's faster and I don't expect dict format to change between
      ns_server and erlang releases
    
    * I've moved computation of aggregate stats into collector which
      should lower CPU consumption and GC pressure of menelaus_stats. The
      only exception is hit_ratio stat, moving which would not be
      equivalent to old behaviour.
    
    * missing stat values are now marked with null which is JSON
      compatible
    
    * previously we prevented samples with missing stat values from being
      served to UI. But now it's not possible, so we don't do it
      anymore. UI adaptation will be performed in next commit.
    
    Change-Id: Ie708ed130c9c5ea193849cd3a9c2846bdbb21a15
    Reviewed-on: http://review.northscale.com/3152
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Sean Lynch <seanl@literati.org>
  3. removed stats_reader:avg/2 which is duplicate from archiver

    Aliaksey Kandratsenka authored and seanlynch committed Oct 7, 2010
    Change-Id: I4debe537ca7b274641ae8cc2e9574ab5bd87830a
    Reviewed-on: http://review.northscale.com/3151
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Sean Lynch <seanl@literati.org>
  4. tweaked failover warning messages

    Aliaksey Kandratsenka authored and alk committed Oct 8, 2010
    Change-Id: I00fc2474c20e010b6f8a2b889f41db13e411a9c5
    Reviewed-on: http://review.northscale.com/3150
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  5. fixed decimation computation for overview graphs resampling

    Aliaksey Kandratsenka authored and seanlynch committed Oct 8, 2010
    Previously we could pick only power of 2 decimation which is too
    aggressive.
    
    Change-Id: I81ece8990cd9ea98f2ef2b0a49c32ee2964c0477
    Reviewed-on: http://review.northscale.com/3148
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Sean Lynch <seanl@literati.org>
  6. log if request execution time is more than 25 seconds. Bug 2722

    Aliaksey Kandratsenka authored and seanlynch committed Oct 7, 2010
    I would like to log even faster requests (like 5 seconds long), but
    our long-polling pool details requests deliberately wait up to 20
    seconds, and it's not very easy to distinguish it from other requests
    at this place.
    
    Change-Id: I4f9ea6bc28fd9e286ec6850393e28968f8caf3f4
    Reviewed-on: http://review.northscale.com/3147
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Sean Lynch <seanl@literati.org>
  7. keep all info when calling XHR error handling functions. Bug 2722

    Aliaksey Kandratsenka authored and seanlynch committed Oct 7, 2010
    Change-Id: I0a1f0a0f57c8c9eda8e5573f5ee0c05876adb0cf
    Reviewed-on: http://review.northscale.com/3146
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Sean Lynch <seanl@literati.org>
  8. Look in same directory as config for init.sql

    seanlynch authored and alk committed Oct 7, 2010
    Change-Id: I7d9ae5a939dbd7dedd2bf8af4adbeec911f7fa12
    Reviewed-on: http://review.northscale.com/3145
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  9. Log config string we use to create a bucket

    seanlynch authored and alk committed Oct 7, 2010
    Change-Id: Ie8dc154d4381669ec7ba63bd20139c18e1d4c63f
    Reviewed-on: http://review.northscale.com/3144
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Commits on Oct 7, 2010
  1. Bug 2715: Just log % of vbuckets lost

    seanlynch authored and alk committed Oct 7, 2010
    Otherwise it would show as a huge list. I tried to make it wrap but it
    printed asterisks instead.
    
    Change-Id: I28c4293458ff461b433911c3449d0c2c53e5a1c8
    Reviewed-on: http://review.northscale.com/3141
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  2. Modify early failure alert to go with dialog, be more clear.

    ingenthr authored and steveyen committed Oct 7, 2010
    Change-Id: If939985cca62fdc0a9836bd148edde14e9a887c8
    Reviewed-on: http://review.northscale.com/3140
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
  3. swapped order of memcached and membase buckets on monitor screen

    Aliaksey Kandratsenka authored and steveyen committed Oct 7, 2010
    Change-Id: I8a9bc7a71e83d6e0e68e571f758c5498374ea9d2
    Reviewed-on: http://review.northscale.com/3137
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  4. remove notifications after fading them out

    Aliaksey Kandratsenka authored and steveyen committed Oct 6, 2010
    Change-Id: I40b3b76f1aeac51920a99e13ecbfb6833a584377
    Reviewed-on: http://review.northscale.com/3136
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  5. hide memory valiation error when switching to join cluster

    Aliaksey Kandratsenka authored and steveyen committed Oct 7, 2010
    Change-Id: Ib6c64995d7dc3a45b5a7114860a0b016ac109164
    Reviewed-on: http://review.northscale.com/3135
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
  6. handle validation errors from setup wizard join request. Bug 2691

    Aliaksey Kandratsenka authored and steveyen committed Oct 7, 2010
    Change-Id: If0b425c49246e580f71279e8de9f0b7283321427
    Reviewed-on: http://review.northscale.com/3134
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  7. cleaned up cluster setup wizard page handling slightly

    Aliaksey Kandratsenka authored and steveyen committed Oct 7, 2010
    Change-Id: Iae9aedd41f76e0f485a16f0339becae727edd432
    Reviewed-on: http://review.northscale.com/3133
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
  8. removed dead variable

    Aliaksey Kandratsenka authored and steveyen committed Oct 7, 2010
    Change-Id: Ibfb6bd3524c263c401b813fa1881525b092db965
    Reviewed-on: http://review.northscale.com/3132
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
  9. shortened more stat names

    Aliaksey Kandratsenka authored and steveyen committed Oct 7, 2010
    Change-Id: If3dae87387e696cdbca4b4a0291e332b04d1254b
    Reviewed-on: http://review.northscale.com/3131
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
  10. issue replicas warning when configing default bucket. Bug 2712

    Aliaksey Kandratsenka authored and steveyen committed Oct 7, 2010
    Change-Id: I022ab72ad95aa0a93c2c7fc9efb58b71b242da7b
    Reviewed-on: http://review.northscale.com/3130
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
  11. Actually delete bucket data files

    seanlynch authored and steveyen committed Oct 7, 2010
    I'd made this fix already but neglected to check it in
    
    Change-Id: I255b630b1c4c011a3ea5db2822150c4a9a73e6dd
    Reviewed-on: http://review.northscale.com/3127
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
  12. Delete files in the data dir when leaving the cluster.

    seanlynch authored and steveyen committed Oct 7, 2010
    Change-Id: Iaee500e1735cdd04f76c58a3a0c2a7a1187f2bbb
    Reviewed-on: http://review.northscale.com/3124
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
  13. Delete files for a bucket when creating it.

    seanlynch authored and steveyen committed Oct 7, 2010
    Change-Id: I7a5ed7dbcdf0e9038adc3266462dafa236f96e4b
    Reviewed-on: http://review.northscale.com/3123
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
  14. Add delete_db_files and delete_all_db_files

    seanlynch authored and steveyen committed Oct 7, 2010
    Change-Id: I3a6cae154777c42fbddf3ccf0ab673f79da785f1
    Reviewed-on: http://review.northscale.com/3122
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
  15. Use db_files/2 to get list of files for sizes.

    seanlynch authored and steveyen committed Oct 7, 2010
    Change-Id: Ibdb448ae308cfe8236e93480718e3626cb2e6833
    Reviewed-on: http://review.northscale.com/3121
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
  16. Add ns_storage_conf:db_files/2

    seanlynch authored and steveyen committed Oct 7, 2010
    This lists the files for a given bucket in a given database path.
    
    Change-Id: Idc1644d2cf6e0f475dd956373eb7da9c2661ae94
    Reviewed-on: http://review.northscale.com/3120
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
  17. Don't delete removed nodes from the Mnesia schema

    seanlynch authored and steveyen committed Oct 6, 2010
    They're harmless, and the deletion seems to occasionally cause Mnesia
    hangs.
    
    Change-Id: I6172398484504f9e6f1ab1ecd595040fe7a41ac0
    Reviewed-on: http://review.northscale.com/3119
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
  18. More reliable ns_memcached:connected

    seanlynch authored and steveyen committed Oct 7, 2010
    This executes a noop command to make sure we're really connected. The
    misc:running method for some reason gave false positives.
    
    Change-Id: I4fce38953b682f4f26e9df8098e66937e27ba37e
    Reviewed-on: http://review.northscale.com/3118
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
  19. return software version and os arch to doctor node info. Bug 2695

    Aliaksey Kandratsenka authored and steveyen committed Oct 7, 2010
    "unknown" OS caused UI to handle pathes in Unix way even when pathes
    were from windows.
    
    Change-Id: I7ca46e527cfe4281e2cfda34aa81560d42a52d7c
    Reviewed-on: http://review.northscale.com/3115
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
  20. shortened stat names

    Aliaksey Kandratsenka authored and alk committed Oct 7, 2010
    Change-Id: I907e5881dd3f94211f4e405dc13e6f21f18dc2f0
    Reviewed-on: http://review.northscale.com/3116
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  21. added warning configuring more replicas then servers. Bug 2318

    Aliaksey Kandratsenka authored and steveyen committed Oct 7, 2010
    Change-Id: I2281fdd91d4ebcdc4d98296cf6294a3c45431646
    Reviewed-on: http://review.northscale.com/3105
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
  22. tweaked Access Control strings on bucket details

    Aliaksey Kandratsenka authored and steveyen committed Oct 6, 2010
    Change-Id: I83202b90e3872c8614a2fe318139dd0cd5536ea3
    Reviewed-on: http://review.northscale.com/3104
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
  23. render failover warnings. Bug 2389

    Aliaksey Kandratsenka authored and steveyen committed Oct 6, 2010
    Change-Id: I92563ba972f4c4b450ba1d263999866c8f09ff65
    Reviewed-on: http://review.northscale.com/3103
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
  24. implemented ns_bucket:failover_warnings/0. Bug 2389

    Aliaksey Kandratsenka authored and steveyen committed Oct 6, 2010
    Change-Id: Ic21ef4fb46df8b066210728bb71ec174b0b9f415
    Reviewed-on: http://review.northscale.com/3102
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
  25. added ns_cluster_membership:actual_active_nodes/0

    Aliaksey Kandratsenka authored and steveyen committed Oct 6, 2010
    Change-Id: Ic1e389e8fd0fa7a492285419bc6e03a104af4cf6
    Reviewed-on: http://review.northscale.com/3101
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
Commits on Oct 6, 2010
  1. handle floating point 0 too when computing hit_ratio. Bug 2690

    Aliaksey Kandratsenka authored and alk committed Oct 6, 2010
    Change-Id: I5d231c91df73f814a6a7e07ff5e8bd3a5aeb3eb8
    Reviewed-on: http://review.northscale.com/3085
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>