Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Jun 3, 2013
  1. @alk

    Revert "MB-8348:added internal setting for use of fadvise in db compa…

    alk authored alk committed
    …ctor"
    
    This reverts commit cbafc77.
    
    MB-8348 is reverted because it was confirmed that couchstore
    optimization indeed regressed some rebalance use cases.
    
    Conflicts:
    	priv/public/index.html
    
    Change-Id: I717b0022d0d154eb0be9d7552dcf606f89d2229a
    Reviewed-on: http://review.couchbase.org/26691
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Commits on May 31, 2013
  1. @alk @aartamonau

    MB-8352: take index path from node details in 1st wizard step

    alk authored aartamonau committed
    I've also removed incorrect escapeHTML in call to #val. It is not
    needed because val is actually doing it via DOM properties and that
    doesn't need any escaping.
    
    Another change is to compute free space for db and index path based on
    mount point disk free space data we have.
    
    Change-Id: I8dc33863c2a4764e08856e9237438bca9798b122
    Reviewed-on: http://review.couchbase.org/26609
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
  2. @alk @aartamonau

    MB-100: fixed funny typo in CHANGES

    alk authored aartamonau committed
    Change-Id: I594fa112cc2b383c6d27d5eee90b4aff56386342
    Reviewed-on: http://review.couchbase.org/26652
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
  3. @alk @aartamonau

    MB-100: wait long enough for child processes shutdown

    alk authored aartamonau committed
    We spotted that we waited for memcached only for 1E6 milliseconds
    which is less than we thought. We found it was caused by
    supervisor_cushion timeout which makes sense to bump to infinity.
    
    Change-Id: Ifc4751ab0b4e44648918a5c291be6299d3cf95db
    Reviewed-on: http://review.couchbase.org/26651
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
  4. @alk @aartamonau

    MB-100: really hide hidden submit on 1st step of wizard

    alk authored aartamonau committed
    Initially this button was visibility:hidden, but we found it prevents
    Enter from submitting form on IE. See
    b01dd0e.
    
    But clearly just forcing it to have 0 width and height doesn't
    completely hide it due to possibly non-zero border, padding and
    margin. But fixing that is easy too.
    
    Change-Id: I60c9de04efbaac5b20e802d8fe3a670ed45c5b43
    Reviewed-on: http://review.couchbase.org/26610
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
  5. @aartamonau @alk

    MB-8379 Always provide default value for num_threads parameter.

    aartamonau authored alk committed
    Change-Id: I2c15bf848eca8eb38b30f30a156e2032fe319d47
    Reviewed-on: http://review.couchbase.org/26653
    Tested-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  6. @aartamonau @alk

    MB-8383 Count {set,del}-return-meta in ops and xdcr_ops.

    aartamonau authored alk committed
    Change-Id: I2071876761438d8c91f635588cfa7d494bf614dd
    Reviewed-on: http://review.couchbase.org/26649
    Tested-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  7. @aartamonau @alk

    MB-8363: implemented readers/writers settings UI

    aartamonau authored alk committed
    Change-Id: Ic202b1ef11205d5b8d820d66f1484c46948402dd
    [stochmail@gmail.com: css/html beautification]
    [alk@tut.by: minor css/html and commit message tweaks]
    Reviewed-on: http://review.couchbase.org/26631
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  8. @aartamonau @alk

    MB-100 Ignore some irrelevant settings for memcached buckets.

    aartamonau authored alk committed
    Change-Id: I4fb450c23b888b6715b47c045824754330a54d47
    Reviewed-on: http://review.couchbase.org/26630
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
Commits on May 30, 2013
  1. @aartamonau @alk

    MB-100 Revert "MB-100: killed addr_util.erl"

    aartamonau authored alk committed
    This reverts commit 1f0b639.
    
    It's still needed for upgrade on Windows.
    
    Change-Id: I171d6e03ab1895ea96916c1bfdd629174f761d2e
    Reviewed-on: http://review.couchbase.org/26594
    Tested-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Commits on May 29, 2013
  1. @alk @aartamonau

    MB-8337: handle 1.8.1 nodes in server details

    alk authored aartamonau committed
    We don't have storage conf for 1.8.x nodes on UI which was causing
    exception on UI. New behavior is to just show empty disk path instead
    of showing nothing at all.
    
    Change-Id: I8c76dd985ea55fdf84435ed2f2097f362dc9f6e6
    Reviewed-on: http://review.couchbase.org/26572
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
  2. @alk @aartamonau

    MB-8329: recover showing of short document part in docs list

    alk authored aartamonau committed
    It partially reverts commit 585c584.
    
    With the following part of revert _not applied_ (i.e. retained).
    
      diff --git a/priv/public/index.html b/priv/public/index.html
      index 12e14b5..59d1668 100644
      --- a/priv/public/index.html
      +++ b/priv/public/index.html
      @@ -1255,6 +1255,10 @@
                               <label for="{%= prefix %}_filter_group_level">group_level</label>
                               <input id="{%= prefix %}_filter_group_level" name="group_level" type="text">
                             </div><!--{% }%}-->
      +                      <!--{% if (items.includeDocs) {%}--><div>
      +                        <label for="{%= prefix %}_filter_include_docs">include_docs</label>
      +                        <input id="{%= prefix %}_filter_include_docs" name="include_docs" type="checkbox">
      +                      </div><!--{% }%}-->
                             <!--{% if (items.inclusiveEnd) {%}--><div>
                               <label for="{%= prefix %}_filter_inclusive_end">inclusive_end</label>
                               <input id="{%= prefix %}_filter_inclusive_end" name="inclusive_end" type="checkbox">
      diff --git a/priv/public/js/filter.js b/priv/public/js/filter.js
      index d8e173a..de099fd 100644
      --- a/priv/public/js/filter.js
      +++ b/priv/public/js/filter.js
      @@ -54,6 +54,7 @@ Filter.prototype = {
             keys: true,
             key: true,
             inclusiveEnd: true,
      +      includeDocs: true,
             groupLevel: true,
             group: true,
             endkeyDocid: true,
    
    Change-Id: I13dff3c0f6bd17fe9872d2a79f8f4c4dec7fde66
    Reviewed-on: http://review.couchbase.org/26571
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
  3. @alk @aartamonau

    MB-100:cbcollect_info: ask windows netstat for process pids

    alk authored aartamonau committed
    I.e. so that we can more clearly see who owns which sockets
    
    Change-Id: Ia01dfa95f955f01ff79308cc9323bd62ab8aee59
    Reviewed-on: http://review.couchbase.org/26568
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
Commits on May 28, 2013
  1. @aartamonau @alk

    MB-8341 Use binary names for all lazily computed stats.

    aartamonau authored alk committed
    Previously we assumed these stats' names to be atoms. That prevented
    XDCR stats from being displayed correctly in 'by server' mode. This
    happened because XDCR stats used binary names. From now all the lazily
    computed stats must use binary names.
    
    Change-Id: I5cf1022314c9e025ff1fa3f9d3143dc9a04a4156
    Reviewed-on: http://review.couchbase.org/26564
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  2. @aartamonau @alk

    [bp] MB-100 Use infinity gen_server timeout in request_throttler.

    aartamonau authored alk committed
    Change-Id: I9815987273cbff6e557dbd29e98f8d407b1f5d43
    Original-Reviewed-on: http://review.couchbase.org/26561
    Original-Tested-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
    Original-Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-on: http://review.couchbase.org/26563
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Commits on May 24, 2013
  1. @alk

    MB-100: removed : after internal settings descriptions

    alk authored alk committed
    Change-Id: Ia5b984acf8f7d73885ea54ccddd9173d185571f6
    Reviewed-on: http://review.couchbase.org/26530
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  2. @alk

    MB-8348:added internal setting for use of fadvise in db compactor

    alk authored alk committed
    Change-Id: I550dfb0b6dd65471437daf40ff4307051f63d8cd
    Reviewed-on: http://review.couchbase.org/26527
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  3. @rmayuram @alk

    MB-8239 Fixed cbcollect_info for OSX.

    rmayuram authored alk committed
    Setting COUCHBASE_TOP env variable here so that erl shell
    script can find erlang install path.
    
    Change-Id: Id666f0658351b7767993a5cad66c10eee12cd6b4
    Reviewed-on: http://review.couchbase.org/26511
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  4. @alk

    MB-100: added more documentation for babysitting VM feature

    alk authored alk committed
    Change-Id: Iba1acae37128eb059f7733beba73057b493e476c
    Reviewed-on: http://review.couchbase.org/26509
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Commits on May 23, 2013
  1. @alk

    MB-8347: advertise cancel XDCR endpoint without typo

    alk authored alk committed
    We still support old call so that if somebody have hardcoded wrong
    path they still have some time to migrate.
    
    Change-Id: Ib6a21e2352f59fd18b6318da6e232726c2df1ccd
    Reviewed-on: http://review.couchbase.org/26505
    Reviewed-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  2. @aartamonau @alk

    MB-100 Don't add version to ns_server install directory.

    aartamonau authored alk committed
    Change-Id: I9b24cf6fe6a89fc9096a59796a54622796980188
    Reviewed-on: http://review.couchbase.org/26502
    Tested-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  3. @aartamonau @alk

    MB-8328 Don't set ERL_MAX_PORTS.

    aartamonau authored alk committed
    The difference in babysitter memory consumption with lowered and
    default values is negligible. And our attempt to unset it for child VM
    was incorrect. It would cause the VM (at least on r14b04 release) to
    set the port limit to 1024. And the latter is much less than what we
    really want.
    
    Change-Id: Ia29aee37711f5c2c59a4ca1932746fc41c94b8ed
    Reviewed-on: http://review.couchbase.org/26501
    Tested-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Commits on May 22, 2013
  1. @aartamonau @alk

    MB-100 Lower the severity of tap_estimate related error messages.

    aartamonau authored alk committed
    We send all the rebalance errors to the user visible log. Particularly
    these error conditions don't really prevent rebalance from completing
    successfully. Moreover, they are normal when mixed versions cluster is
    being rebalanced. So to prevent spamming the user log we just lower
    the severity of these messages.
    
    Change-Id: Iaeb22470200b7a2cf6f96bba1428af30a43da8b4
    Reviewed-on: http://review.couchbase.org/26437
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  2. @aartamonau @alk

    MB-100 Include stats in per node diagnostics.

    aartamonau authored alk committed
    Change-Id: I30518cf5c2969cbb3c329ff8308d35618769b89e
    Reviewed-on: http://review.couchbase.org/26436
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  3. @aartamonau @alk

    MB-8325 Send processes' stats with heartbeat.

    aartamonau authored alk committed
    Change-Id: Ie243e48772a039b73f47e0b73283fb7d645e19da
    Reviewed-on: http://review.couchbase.org/26435
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  4. @aartamonau @alk

    MB-8325 Adapt system_stats_collector to latest portsigar changes.

    aartamonau authored alk committed
    Change-Id: Ibde1162c266ceb3d9c150ff88064217f7ff71eef
    Reviewed-on: http://review.couchbase.org/26434
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Commits on May 21, 2013
  1. @alk @aartamonau

    MB-100: added dev docs for ns_server's usage of checkpoints

    alk authored aartamonau committed
    Change-Id: If16c3ace2407f060e228cb212117af4c27d37e9a
    Reviewed-on: http://review.couchbase.org/26445
    Reviewed-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
    Tested-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
  2. @pavel-blagodov @alk

    MB-8009: update small logo

    pavel-blagodov authored alk committed
    Change-Id: I64d0e326a7ddb93c1ae974199c1d8f283f938b5b
    [alk@tut.by: rebased into branch 2.0.2]
    Signed-off-by: Aliaksey Kandratsenka <alk@tut.by>
    Reviewed-on: http://review.couchbase.org/26440
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Commits on May 20, 2013
  1. @alk @aartamonau

    MB-8309: bump ebucketmigrator's TERMINATE_TIMEOUT

    alk authored aartamonau committed
    So that it more or less matches other recently bumped timeouts.
    
    As part of investigating MB-8309 we saw that we were hitting this
    timeouts in initial phase of old-style vbucket filter change.
    
    Our thinking is this timeouts is indeed needed but given other
    timeouts were bumped and this one did not, we just need to bump this
    one.
    
    Change-Id: Ia8e02a211a094cca87ac866d341d425277247f88
    Reviewed-on: http://review.couchbase.org/26416
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
Commits on May 17, 2013
  1. @alk @aartamonau

    MB-100:cbcollect_info: correctly compute installation root

    alk authored aartamonau committed
    initargs is normally %(root)/var/lib/couchbase/initargs
    
    which is 4 levels above root, not 2 as I previously did
    
    Change-Id: I4ed931de147353de310ed2e045bffcc34c7dce84
    Reviewed-on: http://review.couchbase.org/26393
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
  2. @alk

    MB-100: replaced orddict:find with lists:keysearch

    alk authored alk committed
    Which we already know is much faster. Overall effect on bucket stats
    building appears to be shaving off about 1/3rd of time.
    
    Change-Id: I6393cccf204eb8c16551bdda68ed86993f3b0651
    Reviewed-on: http://review.couchbase.org/26362
    Reviewed-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  3. @aartamonau @alk

    MB-8199 Add entry about request throttling to CHANGES file.

    aartamonau authored alk committed
    Change-Id: I940132e644b7d19d7c8949cf287fa264ecf99f47
    Reviewed-on: http://review.couchbase.org/26361
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  4. @aartamonau @alk

    MB-100 Add a list of commands cbcollect_info depends on.

    aartamonau authored alk committed
    Change-Id: I9d27fe9faad5f67dead6f788df3175bc4edf7866
    Reviewed-on: http://review.couchbase.org/26359
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  5. @alk

    bp:MB-8242: fix outbound XDCR lazy computed stats

    Junyi Xie authored alk committed
    Change-Id: I589627d669639e6083c5d7376a4ca704a87872bb
    Orig-Change-Id: If444c0369b832972b1f809f001e7126a577ac712
    [alk@tut.by: "backported" to 2.0.2]
    Signed-off-by: Aliaksey Kandratsenka <alk@tut.by>
    Reviewed-on: http://review.couchbase.org/26360
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Commits on May 16, 2013
  1. @aartamonau @alk

    MB-8199 Prevent request_throttler from crash if it restarts.

    aartamonau authored alk committed
    Some of our REST endpoints restart almost all the supervision
    tree. Previously note_request_done of such request would be handled
    already by restarted process. This would cause it to crash and would
    fail the request. To prevent this note_request returns throttler pid
    as part of response. Then note_request_done uses this pid. So that new
    instance of request throttler is unaffected. Additionally,
    note_request_done now uses gen_server:cast instead of gen_server:call
    to prevent request handlers from random request_throttler failures.
    
    Change-Id: I9890d586fdfc25364de9153ae54925cb639a0c82
    Reviewed-on: http://review.couchbase.org/26356
    Tested-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Something went wrong with that request. Please try again.