Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Oct 31, 2013
  1. @alk

    bp: MB-9209: fix unbounded worker stats dictionary

    Junyi Xie authored alk committed
    We incorrectly used {<pid>, <unique ref>} from worker processes as
    the key used to store worker stats in the vb replicator state. The
    problem is each time a worker returns a different <unique ref> that
    causes a new entry is created when worker reports stats to the vb
    replicator. Overtime, the stats table will increase unboundedly,
    causing memory leak. This fix uses a unique worker id to identify
    each worker process and use that id as the key of worker stats table.
    Thus the number of entries of vb stats table will be bounded by the
    number of worker processes (default is 4).
    
    Change-Id: Ic5cc7b1a9df4a0d587ce786f719414ee25c89246
    [alk@tut.by: re-gerriting against 2.1.0]
    Signed-off-by: Aliaksey Kandratsenka <alk@tut.by>
    Reviewed-on: http://review.couchbase.org/29912
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Commits on Jul 17, 2013
  1. @alk @aartamonau

    bp:MB-8545: do not allow node self-rename if name is set manually

    alk authored aartamonau committed
    Change-Id: I4492a2c3ee4822e7439b531fb39b6ba6e459a421
    Orig-Reviewed-on: http://review.couchbase.org/27264
    Reviewed-on: http://review.couchbase.org/27518
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
Commits on Jun 10, 2013
  1. @aartamonau @alk

    MB-100 Really set default number of readers/writers to 3.

    aartamonau authored alk committed
    Change-Id: I64d014ead6a90a706a6ff030023115eecf7250c0
    Reviewed-on: http://review.couchbase.org/26871
    Tested-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
    Reviewed-by: Jin Lim <jin@couchbase.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Commits on Jun 8, 2013
  1. @jinlim

    MB-8415 set minum num_threads back to 2 and set default to 3

    jinlim authored
    Change-Id: Ib82f15f31155dd8f9e4f37073b27115f300549d2
    Reviewed-on: http://review.couchbase.org/26796
    Reviewed-by: Jin Lim <jin@couchbase.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Jin Lim <jin@couchbase.com>
  2. @alk @jinlim

    Revert "Revert "MB-8415 change engine...""

    alk authored jinlim committed
    This reverts commit a165d1c10cf0071571cd3787a0b7c5a5cae3f391.
    
    This returns original commit which was just reverted in order to let
    ep-engine folks review their corresponding change.
    
    Change-Id: Ied466f51f2ee648c350e1b2b490bbe78576f624b
    Reviewed-on: http://review.couchbase.org/26787
    Reviewed-by: Jin Lim <jin@couchbase.com>
    Tested-by: Jin Lim <jin@couchbase.com>
  3. @alk @aartamonau

    MB-8429: grab memcached logs in osx too

    alk authored aartamonau committed
    Clearly grabbing memcached logs is not Linux-specific and thanks to
    "server guts" we should have right path regardless of OS or customer
    setup.
    
    Change-Id: Ie8320b9a872c035b9b8a809b6caf86e6f02e8022
    Reviewed-on: http://review.couchbase.org/26841
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
Commits on Jun 6, 2013
  1. @aartamonau @alk

    MB-8383 Count ret_meta commands as their ordinary counterparts.

    aartamonau authored alk committed
    And don't count them as xdcr ops.
    
    Change-Id: Ic0eae1f5f9bdb95cfcb1ab78cb0ca22336c5ce0c
    Reviewed-on: http://review.couchbase.org/26806
    Tested-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  2. @alk

    MB-7363: don't allow stacking of same poor man's alerts

    alk authored alk committed
    Part of poor man's alerts is alert "key" which is used to prevent
    duplicate alerts from reappering too often. We can use that same key
    in order for fresher alerts to overwrite older alerts for same key.
    
    This commit also makes metadata overhead and commit failure alerts
    have per-bucket keys. So that alerts related to different buckets are
    treated as separate alerts.
    
    Change-Id: Ib6146b0a53d2b96c7dd5adf0c9998f3d51855df6
    Reviewed-on: http://review.couchbase.org/26802
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  3. @alk

    Revert "MB-8415 change engine parameter num_shards to num_workers"

    alk authored alk committed
    This reverts commit c84d26d.
    
    Change-Id: Ic17b36277106f7de77a351e0ce8d8dc45e675e02
    Reviewed-on: http://review.couchbase.org/26786
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  4. @jinlim @alk

    MB-8415 change engine parameter num_shards to num_workers

    jinlim authored alk committed
    Change-Id: I5035442233e1208e7a9a7540382a38ba4dec810a
    Reviewed-on: http://review.couchbase.org/26776
    Tested-by: Jin Lim <jin@couchbase.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Commits on Jun 5, 2013
  1. @alk @aartamonau

    MB-8404: prevent replacing 127.0.0.1 in engageCluster reply

    alk authored aartamonau committed
    That replacement is usually needed for single-node clusters where node
    name is 127.0.0.1. And where we cannot send 127.0.0.1 because that
    will cause client to try to reach memcached (or moxi) at wrong
    address.
    
    But clearly this renaming is not needed in engageCluster which is
    intra-cluster API. And also this renaming was actual reason why our
    normally very strict pre-join checks failed to detect badness of
    trying to join 127.0.0.1.
    
    Change-Id: I34bb56d0018ae626adb8b79f5ac603ef3c434569
    Reviewed-on: http://review.couchbase.org/26738
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
  2. @aartamonau @alk

    MB-8363 Set numThreads minimum value to 1.

    aartamonau authored alk committed
    Change-Id: Ic273744c1076501031af2ba0a9bb6d43368ff23d
    Reviewed-on: http://review.couchbase.org/26737
    Tested-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Commits on Jun 4, 2013
  1. @alk

    Merge remote-tracking branch 'origin/2.0.2' into b210

    alk authored
    * origin/2.0.2:
      Revert "MB-8348:added internal setting for use of fadvise in db compactor"
    
    trivial
    
    Change-Id: Iacf9d1a17d6d69571d9141ec0bd52fc1f69a26f1
  2. 2.1.0 branch at build 2.0.2-824

    Phil Labee authored
    Change-Id: I3695c6d3fdc95eccd415722114e75df0b79f984a
    Reviewed-on: http://review.couchbase.org/26698
    Reviewed-by: Philip Labee <philip@couchbase.com>
    Tested-by: Philip Labee <philip@couchbase.com>
Commits on Jun 3, 2013
  1. @alk

    Revert "MB-8348:added internal setting for use of fadvise in db compa…

    alk authored alk committed
    …ctor"
    
    This reverts commit cbafc77.
    
    MB-8348 is reverted because it was confirmed that couchstore
    optimization indeed regressed some rebalance use cases.
    
    Conflicts:
    	priv/public/index.html
    
    Change-Id: I717b0022d0d154eb0be9d7552dcf606f89d2229a
    Reviewed-on: http://review.couchbase.org/26691
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Commits on May 31, 2013
  1. @alk @aartamonau

    MB-8352: take index path from node details in 1st wizard step

    alk authored aartamonau committed
    I've also removed incorrect escapeHTML in call to #val. It is not
    needed because val is actually doing it via DOM properties and that
    doesn't need any escaping.
    
    Another change is to compute free space for db and index path based on
    mount point disk free space data we have.
    
    Change-Id: I8dc33863c2a4764e08856e9237438bca9798b122
    Reviewed-on: http://review.couchbase.org/26609
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
  2. @alk @aartamonau

    MB-100: fixed funny typo in CHANGES

    alk authored aartamonau committed
    Change-Id: I594fa112cc2b383c6d27d5eee90b4aff56386342
    Reviewed-on: http://review.couchbase.org/26652
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
  3. @alk @aartamonau

    MB-100: wait long enough for child processes shutdown

    alk authored aartamonau committed
    We spotted that we waited for memcached only for 1E6 milliseconds
    which is less than we thought. We found it was caused by
    supervisor_cushion timeout which makes sense to bump to infinity.
    
    Change-Id: Ifc4751ab0b4e44648918a5c291be6299d3cf95db
    Reviewed-on: http://review.couchbase.org/26651
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
  4. @alk @aartamonau

    MB-100: really hide hidden submit on 1st step of wizard

    alk authored aartamonau committed
    Initially this button was visibility:hidden, but we found it prevents
    Enter from submitting form on IE. See
    b01dd0e.
    
    But clearly just forcing it to have 0 width and height doesn't
    completely hide it due to possibly non-zero border, padding and
    margin. But fixing that is easy too.
    
    Change-Id: I60c9de04efbaac5b20e802d8fe3a670ed45c5b43
    Reviewed-on: http://review.couchbase.org/26610
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
  5. @aartamonau @alk

    MB-8379 Always provide default value for num_threads parameter.

    aartamonau authored alk committed
    Change-Id: I2c15bf848eca8eb38b30f30a156e2032fe319d47
    Reviewed-on: http://review.couchbase.org/26653
    Tested-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  6. @aartamonau @alk

    MB-8383 Count {set,del}-return-meta in ops and xdcr_ops.

    aartamonau authored alk committed
    Change-Id: I2071876761438d8c91f635588cfa7d494bf614dd
    Reviewed-on: http://review.couchbase.org/26649
    Tested-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  7. @aartamonau @alk

    MB-8363: implemented readers/writers settings UI

    aartamonau authored alk committed
    Change-Id: Ic202b1ef11205d5b8d820d66f1484c46948402dd
    [stochmail@gmail.com: css/html beautification]
    [alk@tut.by: minor css/html and commit message tweaks]
    Reviewed-on: http://review.couchbase.org/26631
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  8. @aartamonau @alk

    MB-100 Ignore some irrelevant settings for memcached buckets.

    aartamonau authored alk committed
    Change-Id: I4fb450c23b888b6715b47c045824754330a54d47
    Reviewed-on: http://review.couchbase.org/26630
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
Commits on May 30, 2013
  1. @aartamonau @alk

    MB-100 Revert "MB-100: killed addr_util.erl"

    aartamonau authored alk committed
    This reverts commit 1f0b639.
    
    It's still needed for upgrade on Windows.
    
    Change-Id: I171d6e03ab1895ea96916c1bfdd629174f761d2e
    Reviewed-on: http://review.couchbase.org/26594
    Tested-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Commits on May 29, 2013
  1. @alk @aartamonau

    MB-8337: handle 1.8.1 nodes in server details

    alk authored aartamonau committed
    We don't have storage conf for 1.8.x nodes on UI which was causing
    exception on UI. New behavior is to just show empty disk path instead
    of showing nothing at all.
    
    Change-Id: I8c76dd985ea55fdf84435ed2f2097f362dc9f6e6
    Reviewed-on: http://review.couchbase.org/26572
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
  2. @alk @aartamonau

    MB-8329: recover showing of short document part in docs list

    alk authored aartamonau committed
    It partially reverts commit 585c584.
    
    With the following part of revert _not applied_ (i.e. retained).
    
      diff --git a/priv/public/index.html b/priv/public/index.html
      index 12e14b5..59d1668 100644
      --- a/priv/public/index.html
      +++ b/priv/public/index.html
      @@ -1255,6 +1255,10 @@
                               <label for="{%= prefix %}_filter_group_level">group_level</label>
                               <input id="{%= prefix %}_filter_group_level" name="group_level" type="text">
                             </div><!--{% }%}-->
      +                      <!--{% if (items.includeDocs) {%}--><div>
      +                        <label for="{%= prefix %}_filter_include_docs">include_docs</label>
      +                        <input id="{%= prefix %}_filter_include_docs" name="include_docs" type="checkbox">
      +                      </div><!--{% }%}-->
                             <!--{% if (items.inclusiveEnd) {%}--><div>
                               <label for="{%= prefix %}_filter_inclusive_end">inclusive_end</label>
                               <input id="{%= prefix %}_filter_inclusive_end" name="inclusive_end" type="checkbox">
      diff --git a/priv/public/js/filter.js b/priv/public/js/filter.js
      index d8e173a..de099fd 100644
      --- a/priv/public/js/filter.js
      +++ b/priv/public/js/filter.js
      @@ -54,6 +54,7 @@ Filter.prototype = {
             keys: true,
             key: true,
             inclusiveEnd: true,
      +      includeDocs: true,
             groupLevel: true,
             group: true,
             endkeyDocid: true,
    
    Change-Id: I13dff3c0f6bd17fe9872d2a79f8f4c4dec7fde66
    Reviewed-on: http://review.couchbase.org/26571
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
  3. @alk @aartamonau

    MB-100:cbcollect_info: ask windows netstat for process pids

    alk authored aartamonau committed
    I.e. so that we can more clearly see who owns which sockets
    
    Change-Id: Ia01dfa95f955f01ff79308cc9323bd62ab8aee59
    Reviewed-on: http://review.couchbase.org/26568
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
Commits on May 28, 2013
  1. @aartamonau @alk

    MB-8341 Use binary names for all lazily computed stats.

    aartamonau authored alk committed
    Previously we assumed these stats' names to be atoms. That prevented
    XDCR stats from being displayed correctly in 'by server' mode. This
    happened because XDCR stats used binary names. From now all the lazily
    computed stats must use binary names.
    
    Change-Id: I5cf1022314c9e025ff1fa3f9d3143dc9a04a4156
    Reviewed-on: http://review.couchbase.org/26564
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  2. @aartamonau @alk

    [bp] MB-100 Use infinity gen_server timeout in request_throttler.

    aartamonau authored alk committed
    Change-Id: I9815987273cbff6e557dbd29e98f8d407b1f5d43
    Original-Reviewed-on: http://review.couchbase.org/26561
    Original-Tested-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
    Original-Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-on: http://review.couchbase.org/26563
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Commits on May 24, 2013
  1. @alk

    MB-100: removed : after internal settings descriptions

    alk authored alk committed
    Change-Id: Ia5b984acf8f7d73885ea54ccddd9173d185571f6
    Reviewed-on: http://review.couchbase.org/26530
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  2. @alk

    MB-8348:added internal setting for use of fadvise in db compactor

    alk authored alk committed
    Change-Id: I550dfb0b6dd65471437daf40ff4307051f63d8cd
    Reviewed-on: http://review.couchbase.org/26527
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  3. @rmayuram @alk

    MB-8239 Fixed cbcollect_info for OSX.

    rmayuram authored alk committed
    Setting COUCHBASE_TOP env variable here so that erl shell
    script can find erlang install path.
    
    Change-Id: Id666f0658351b7767993a5cad66c10eee12cd6b4
    Reviewed-on: http://review.couchbase.org/26511
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  4. @alk

    MB-100: added more documentation for babysitting VM feature

    alk authored alk committed
    Change-Id: Iba1acae37128eb059f7733beba73057b493e476c
    Reviewed-on: http://review.couchbase.org/26509
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Commits on May 23, 2013
  1. @alk

    MB-8347: advertise cancel XDCR endpoint without typo

    alk authored alk committed
    We still support old call so that if somebody have hardcoded wrong
    path they still have some time to migrate.
    
    Change-Id: Ib6a21e2352f59fd18b6318da6e232726c2df1ccd
    Reviewed-on: http://review.couchbase.org/26505
    Reviewed-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
  2. @aartamonau @alk

    MB-100 Don't add version to ns_server install directory.

    aartamonau authored alk committed
    Change-Id: I9b24cf6fe6a89fc9096a59796a54622796980188
    Reviewed-on: http://review.couchbase.org/26502
    Tested-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Something went wrong with that request. Please try again.