Commits on Aug 24, 2011
  1. @aartamonau @steveyen

    Add initial vclock to per node keys that changed since 1.6.5.

    This change fixes MB-4219.
    
    When config merging routines encounter two values not having vclocks
    attached to them then the value that came from remote node is
    chosen. This can cause certain races. Particularly this is the cause
    of upgrade issues seen on windows: when node is started for the first
    time it upgrades old config but then it pulls the config from other
    nodes and prefers foreign value (outdated one) to its own. This change
    introduces initial vclocks for such vulnerable keys so that new values
    will be preferred.
    
    Change-Id: Ibe85213eb8df2392f6b4b34413062c0aed19c0a1
    Reviewed-on: http://review.couchbase.org/9206
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    aartamonau committed with steveyen Aug 24, 2011
Commits on Aug 15, 2011
  1. @aartamonau @steveyen

    MB-4180 Fix grabbing diag.

    Before Erlang R14B02 it was possible to call restart_child on
    processes with temporary restart type though it was not something
    anyone supposed to do. R14B02 stopped saving initial arguments for
    temporary processes to save some memory. Though child specifications
    of such processes were still saved. Thus an attempt to restart_child
    temporary process would cause an error. This must be fixed in R14B03
    where child specifications of temporary processes are cleaned up
    properly and no one should see {error, already_present}.
    Some details:
      http://erlang.org/pipermail/erlang-bugs/2011-March/002273.html
    
    Change-Id: I62b6d2979e989bbd685e1029a75471e31bc5af82
    Reviewed-on: http://review.couchbase.org/8945
    Tested-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Steve Yen <steve.yen@gmail.com>
    aartamonau committed with steveyen Aug 15, 2011
  2. @steveyen

    save config after config cas. MB-4186

    We need to initiate config saving after each config update. config cas was
    missing that, sadly.
    
    Change-Id: I60de70ee2674b2e73c82096604673998b263afb3
    Reviewed-on: http://review.couchbase.org/8946
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
    Aliaksey Kandratsenka committed with steveyen Aug 15, 2011
Commits on Aug 9, 2011
  1. @bcui6611

    MB-3961 Work around inet:getiflist() bug under multi-home

    inet:getiflist() doesn't work well if multi-ipaddress are configured.
    Both uuid.erl and addr_utils.erl depend on this function. As such,
    either we use inet:getifadrs() and reimplement uuid to remove this
    dependency.
    
    Change-Id: Ie5d4f44e9201f1bf78f4bcae6aa7472b50086d93
    Reviewed-on: http://review.couchbase.org/8653
    Tested-by: Bin Cui <bin.cui@gmail.com>
    Reviewed-by: Filipe David Borba Manana <fdmanana@gmail.com>
    Tested-by: Filipe David Borba Manana <fdmanana@gmail.com>
    bcui6611 committed Aug 5, 2011
Commits on Jul 23, 2011
  1. @steveyen

    added documentation on cluster joining sequence

    Change-Id: I43fc4b12860c19e04023fd5384699bead0b42c01
    Reviewed-on: http://review.couchbase.org/8289
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Aliaksey Kandratsenka committed with steveyen Jul 23, 2011
  2. @steveyen

    prevent 1.7.1 node joining 1.6.x cluster and vice versa

    Change-Id: Iaa411340d31f82de7690772c1beeb1c0e4b66570
    Reviewed-on: http://review.couchbase.org/8290
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Aliaksey Kandratsenka committed with steveyen Jul 23, 2011
Commits on Jul 19, 2011
  1. @steveyen

    raise ebucketmigrator's upstream timeout to 10 minutes

    Because it makes sense to keep trying instead of failing rebalance.
    
    Change-Id: I60f61f19230732f41960552ff6ceadb905f4207a
    Reviewed-on: http://review.couchbase.org/8084
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Aliaksey Kandratsenka committed with steveyen Jul 17, 2011
  2. @steveyen

    don't use best_effort option of janitor

    Because it can try replicating to/from not ready node. It's much safer
    to expect all nodes to be healthy.
    
    Change-Id: Ieb7ba1c3451e1dcd3589ab5af6c33840b66dcbd4
    Reviewed-on: http://review.couchbase.org/8157
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Steve Yen <steve.yen@gmail.com>
    Aliaksey Kandratsenka committed with steveyen Jul 19, 2011
Commits on Jul 16, 2011
  1. @vmx @alk

    Display a warning when node was auto-failovered. MB-4074

    When a node was auto-failovered, display a warning at the server
    screen including a "reset quota" button.
    The quota can also be reset on the settings screen. It will only
    be displayed if there is something to reset.
    
    When an error occurs a popup is shown.
    
    This commit fixes MB-4074.
    
    Change-Id: Id1e4d0d559d6563577ab9fb079bed6b8919d6b0d
    [alk@tut.by: hide auto-failover warning by default]
    Signed-off-by: Aliaksey Kandratsenka <alk@tut.by>
    Reviewed-on: http://review.couchbase.org/8010
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    vmx committed with alk Jul 14, 2011
  2. @steveyen @farshidce

    Revert "Revert "batch replication changes during rebalance""

    This reverts commit d6663ae.
    
    Change-Id: Idd2f1d1610a25b5a94d6ec11742eb4c3890da235
    Reviewed-on: http://review.couchbase.org/8048
    Tested-by: Farshid Ghods <farshid.ghods@gmail.com>
    Reviewed-by: Farshid Ghods <farshid.ghods@gmail.com>
    steveyen committed with farshidce Jul 15, 2011
Commits on Jul 15, 2011
  1. @alk

    ignore memcached buckets in janitor:cleanup

    Right after bucket creation we request janitor run. Regardless of
    bucket type. This leads to janitor crash on memcached buckets.
    
    Because janitor was never intended to handle memcached bucket types it
    makes sense to cover memcached bucket types in janitor.
    
    Change-Id: Ifc3b36f9b2efbbf1e4ea47050f33e28fe393af9e
    Reviewed-on: http://review.couchbase.org/7987
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
    Aliaksey Kandratsenka committed with alk Jul 14, 2011
Commits on Jul 12, 2011
  1. @steveyen

    Revert "batch replication changes during rebalance"

    This reverts commit 9d821b1.
    
    When a user uses "Stop Rebalance", some replication streams
    were not correctly resumed after the stopping.
    
    Change-Id: I71ad67a5d6522cb92a57323675049d92ac026794
    Reviewed-on: http://review.couchbase.org/7925
    Tested-by: Srinivas Vadlamani <srinivas@couchbase.com>
    Reviewed-by: Srinivas Vadlamani <srinivas@couchbase.com>
    steveyen committed with Srinivas Vadlamani Jul 12, 2011
  2. @steveyen

    membase/memcached bucket min RAM quota are cmd-line configurable.

    For many-bucket testing, the ability to change the minimum RAM quota
    for buckets is useful.  For example, to get a 5 MB minimum
    membase-type bucket RAM quota, append this when running the erl...
    
      erl ... -ns_server membase_min_ram_quota 5
    
    The new keys are membase_min_ram_quota and memcached_min_ram_quota.
    
    Change-Id: Ic43b0bc8b1608bb13cde8cdbfcc5152b3bc511b3
    Reviewed-on: http://review.couchbase.org/7899
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Dale Harvey <daleharvey@arandomurl.com>
    Reviewed-by: Dale Harvey <daleharvey@arandomurl.com>
    steveyen committed with Dale Harvey Jul 11, 2011
  3. @steveyen

    Command-line configurable grab_stats_every_n_ticks

    During cloud multitenancy testing of many buckets, stats gathering was
    a CPU consumption culprit.  Allow stats capture to be less often by
    command-line configuration.
    
    Change-Id: I93632ce1b6d6f96d26a78d2cf5a19a82a2c2bc60
    Reviewed-on: http://review.couchbase.org/7897
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Dale Harvey <daleharvey@arandomurl.com>
    Reviewed-by: Dale Harvey <daleharvey@arandomurl.com>
    steveyen committed with Dale Harvey Jul 11, 2011
  4. @steveyen

    Allow ns_tick interval to be cmd-line overridable.

    This allows for easier testing of different cloud configurations.
    
    Change-Id: I05b5c60243a501e46c747f6d6b447c305a4852dd
    Reviewed-on: http://review.couchbase.org/7895
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Dale Harvey <daleharvey@arandomurl.com>
    Reviewed-by: Dale Harvey <daleharvey@arandomurl.com>
    steveyen committed with Dale Harvey Jul 11, 2011
  5. @steveyen

    Removed unused defines

    Change-Id: I226b753869d25b2e2060222c4cd287aab758ed87
    Reviewed-on: http://review.couchbase.org/7894
    Tested-by: Steve Yen <steve.yen@gmail.com>
    Tested-by: Dale Harvey <daleharvey@arandomurl.com>
    Reviewed-by: Dale Harvey <daleharvey@arandomurl.com>
    steveyen committed with Dale Harvey Jul 11, 2011
Commits on Jul 11, 2011
  1. @vmx @alk

    Make auto-failover common_tests work with current version.

    The config key changed from auto_failover to auto_failover_cfg.
    
    Change-Id: Ie7a9ab9e765280f5a148532654f5c46c6c060f95
    Reviewed-on: http://review.couchbase.org/7772
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    vmx committed with alk Jul 7, 2011
  2. @vmx @alk

    Always send mails when node can't be auto-failovered.

    If a node goes down and the maximum number of nodes
    that may be auto-failovered is already reached, a
    notification email will be send.
    
    Change-Id: I8e3cb4fc17e53fbe0292a3220bafa7ae1a4a5b1c
    Reviewed-on: http://review.couchbase.org/7770
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    vmx committed with alk Jul 7, 2011
Commits on Jul 8, 2011
  1. @bcui6611

    log vbucket mover's pids for better rebalance logging

    Currently we have quite verbose replication logging. But rebalance
    ebucketmigrators are a bit less verbose. During recent bug
    investigation lack of this information was impediment.
    
    Change-Id: I1d7d3ccbf31b76568c01c0de8e4e2e890055588d
    Reviewed-on: http://review.couchbase.org/7816
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Bin Cui <bin.cui@gmail.com>
    Aliaksey Kandratsenka committed with bcui6611 Jul 8, 2011
  2. @sharonyb

    fixed support forum link. MB-3951

    Change-Id: I953203f1a4ab7b632542308a78aa29e70c6c1335
    Reviewed-on: http://review.couchbase.org/7818
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Sharon Barr <sharonyb@gmail.com>
    Aliaksey Kandratsenka committed with sharonyb Jul 8, 2011
Commits on Jul 7, 2011
  1. @bcui6611

    double amount of preserved logs

    Change-Id: I7647409a957b3dadf500268b24e6bc971ff4a71b
    Reviewed-on: http://review.couchbase.org/7768
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Bin Cui <bin.cui@gmail.com>
    Aliaksey Kandratsenka committed with bcui6611 Jul 7, 2011
  2. @bcui6611

    round too small swap usage percentage numbers down to 0.MB-3927

    Least scale 10 and display of 3 digits means that we're requesting one
    digit after point. E.g. 88.1, 8.1, 0.1 and 0.
    
    Change-Id: Ib1dee757c1f7bb5886b6c8334849172ef7ec018b
    Reviewed-on: http://review.couchbase.org/7740
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Bin Cui <bin.cui@gmail.com>
    Aliaksey Kandratsenka committed with bcui6611 Jul 6, 2011
Commits on Jul 6, 2011
  1. @vmx @alk

    Use current settings for test email and display errors. MB-4029, MB-4031

    The "Test email" button for the auto-failover email alerts
    not uses the settings as set above, they don't need to be
    (and won't be) saved.
    
    In case the sending of the email didn't work, the button
    will display "Error!" and will be disabled until the
    settings got changed.
    
    This commits also contains the removal of some log messages
    that were there for debug purpose only.
    
    This commit fixes MB-4029 and MB-4031.
    
    Change-Id: Ida9218ceefea7fe4a2681592c2fed9c7a83afa70
    Reviewed-on: http://review.couchbase.org/7745
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    vmx committed with alk Jul 6, 2011
  2. @vmx @alk

    Auto-failover mails mention node. MB-4028

    The auto-failover alert mails do now mention the node
    that was/couldn't be failovered.
    othenodesdown mentions all nodes that are currently down.
     - auto_failover_node mentions the node that was failovered
     - auto_failover_other_nodes_down mentions all nodes that are
    currently down.
     - auto_failover_cluster_too_small mentions the node that couldn't
    be auto-failvored
     - auto_failvoer_maximum_reached doesn't mention any nodes, as it
    is sent out only once. It would be misleading to mention a node on
    the first time, but when another node goes not sending out any info.
    The admin should just check what went wrong. Also, this is an
    auto-failover alert and not a general "node down"-alert.
    
    This commit fixes MB-4028.
    
    Change-Id: I9df8c73d8b7c7be68f2813c9086b50aa2e804f32
    Reviewed-on: http://review.couchbase.org/7743
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    vmx committed with alk Jul 6, 2011
  3. @BigBlueHat @alk

    altering position CSS property on window resize to fix MB-3997

    Change-Id: Id1ec50a474474451c4bb99788caeb86e87772e17
    Reviewed-on: http://review.couchbase.org/7637
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    BigBlueHat committed with alk Jun 29, 2011
Commits on Jul 5, 2011
  1. @bcui6611

    removed TLS checkbox for alert email settings

    Because we don't ship crypto in 1.7.x.
    
    Change-Id: I023218528caa2bb786066d68faeac1e42de1559f
    Reviewed-on: http://review.couchbase.org/7737
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Bin Cui <bin.cui@gmail.com>
    Aliaksey Kandratsenka committed with bcui6611 Jul 6, 2011
  2. @bcui6611

    disable tls by default

    So that missing crypto doesn't affect our ability to send emails.
    
    Change-Id: Ic12ff064fa0fa74bc265962f715669d74766b299
    Reviewed-on: http://review.couchbase.org/7736
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Bin Cui <bin.cui@gmail.com>
    Aliaksey Kandratsenka committed with bcui6611 Jul 6, 2011
  3. @bcui6611

    package gen_smtp for alerts emails sending. MB-4024

    Change-Id: I2bf839cffa908341dbcbb0b47ed2e7c68a9c1986
    Reviewed-on: http://review.couchbase.org/7735
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Bin Cui <bin.cui@gmail.com>
    Aliaksey Kandratsenka committed with bcui6611 Jul 6, 2011
  4. @bcui6611

    implemented config upgrade to 1.7.1. MB-4018

    This fixes in-place upgrade part of MB-4018
    
    Change-Id: I48809a2e3cf37a7b3d6845f525a129a35921fa3d
    Reviewed-on: http://review.couchbase.org/7733
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Bin Cui <bin.cui@gmail.com>
    Aliaksey Kandratsenka committed with bcui6611 Jul 5, 2011
  5. @bcui6611

    using new config keys for autofailover and alerts. MB-4018

    Otherwise joining 1.7.0 cluster will keep old (and incorrect) config
    values.
    
    We've changed 'schema' of this keys. Old alerts are not used, and
    previously autofailover was experimental. So this is kind of new
    features.
    
    Change-Id: If154e1eb34779f4761337558512152a684bf954b
    Reviewed-on: http://review.couchbase.org/7732
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Bin Cui <bin.cui@gmail.com>
    Aliaksey Kandratsenka committed with bcui6611 Jul 6, 2011
  6. @vmx @bcui6611

    Make common_tests work with new auto-failover.

    All tests of the auto-failover common_tests suite now pass
    on the new implementation of autp-failover.
    
    Change-Id: I609d3f9fd0e0eb8e4bf7dc59fff145133a2f9821
    Reviewed-on: http://review.couchbase.org/7728
    Reviewed-by: Bin Cui <bin.cui@gmail.com>
    Tested-by: Bin Cui <bin.cui@gmail.com>
    vmx committed with bcui6611 Jul 5, 2011
  7. @bcui6611

    fixed typo

    Change-Id: If014287130857c122d7d13a9c8d1eab5d8e0f299
    Reviewed-on: http://review.couchbase.org/7722
    Reviewed-by: Bin Cui <bin.cui@gmail.com>
    Tested-by: Bin Cui <bin.cui@gmail.com>
    Aliaksey Kandratsenka committed with bcui6611 Jul 5, 2011
  8. @bcui6611

    added ns_cluster_membership:active_nodes/1

    Change-Id: I1d18b6c955e095e4f46c63ad34acef22ff3c23bd
    Reviewed-on: http://review.couchbase.org/7719
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Bin Cui <bin.cui@gmail.com>
    Aliaksey Kandratsenka committed with bcui6611 Jul 4, 2011
  9. @bcui6611

    extracted hearbeat period into header file

    Change-Id: I5a268ced67118dfa4532c89b315331b2a9012066
    Reviewed-on: http://review.couchbase.org/7718
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Bin Cui <bin.cui@gmail.com>
    Aliaksey Kandratsenka committed with bcui6611 Jul 4, 2011
  10. @bcui6611

    broadcast hearbeats in parallel

    So that slow network to some node(s) cannot delay hearbeats to entire
    cluster. This also moves heartbeat/1 to ns_heart.
    
    Change-Id: Id700309cbbe467ef6b46390faeffb485cce441a4
    Reviewed-on: http://review.couchbase.org/7717
    Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
    Reviewed-by: Bin Cui <bin.cui@gmail.com>
    Aliaksey Kandratsenka committed with bcui6611 Jul 4, 2011