Permalink
Commits on Oct 11, 2017
  1. Breakpad not available (nor required) on MacOS

    ceejatec committed Oct 11, 2017
    Change-Id: Ice3be606989f7d5716f08e76cc6aec8e4b7cc739
    Reviewed-on: http://review.couchbase.org/84257
    Tested-by: Build Bot <build@couchbase.com>
    Reviewed-by: Chris Hillery <ceej@couchbase.com>
  2. Make clear distinction regarding cbdeps for supported/unsupported pla…

    ceejatec committed Oct 11, 2017
    …tforms
    
    Change-Id: I9066c811cb78f29fc4c710e19e3ed2b01f59b50f
    Reviewed-on: http://review.couchbase.org/84245
    Tested-by: Build Bot <build@couchbase.com>
    Reviewed-by: Chris Hillery <ceej@couchbase.com>
Commits on Oct 10, 2017
  1. MB-26298 [2/2] [RocksDB] Use the new `Fast CRC32`-enabled library

    paolococchi committed Oct 9, 2017
    With this change we use the new RocksDB library that enables Fast CRC32.
    
    Change-Id: Ifc4dcc1df41c228c1ba3112f5dcae428e5c522ef
    Reviewed-on: http://review.couchbase.org/84141
    Reviewed-by: Dave Rigby <daver@couchbase.com>
    Tested-by: Build Bot <build@couchbase.com>
Commits on Oct 9, 2017
  1. MB-26298 [1/2] [RocksDB] Re-enable Fast CRC32 with `USE_SSE=1`

    paolococchi committed with daverigby Oct 9, 2017
    With the build option `USE_SSE=1` we add support for SSE4.2. The
    generated library contains SSE4.2 code, but RocksDB performs a runtime
    check to decide whether to use the SSE4.2 code or not, depending on if
    the machine supports it. Thus, we still guarantee portability.
    
    Change-Id: I3a3fb5d7577755450d636703d69f5c161f71d1e8
    Reviewed-on: http://review.couchbase.org/84140
    Reviewed-by: Dave Rigby <daver@couchbase.com>
    Tested-by: Build Bot <build@couchbase.com>
Commits on Oct 7, 2017
  1. MB-26295 Add CB_NON_PRODUCTION_ASSERTS CMake option, initially OFF

    daverigby committed with trondn Oct 5, 2017
    It is desirable to add asserts in the codebase for functionality which
    is non-critical - while we want to expose bugs early in development /
    testing (via an asset/exception firing), we don't want to trigger such
    asserts in production.  For example, asserting that statistical
    counters are of an expected range (don't underflow) - we would like to
    detect such bugs; but they arn't serious enough to warrant crashing in
    a customer environment.
    
    As such, add a new CMake option - CB_DEVELOPMENT_ASSERTS - which can
    be used to guard such checks. This will be enabled during the
    development phase of a release; but disabled before Beta/Pre-Release.
    
    Change-Id: Ide87c48e6ff54ddcb6fd696e4c5464c9ae62f551
    Reviewed-on: http://review.couchbase.org/84095
    Tested-by: Build Bot <build@couchbase.com>
    Reviewed-by: Chris Hillery <ceej@couchbase.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
Commits on Oct 6, 2017
  1. MB-26260: Add numactl cbdep for Linux only

    Kenneth Lareau committed Oct 6, 2017
    This is for the RocksDB cbdep to ensure libnuma is installed as well
    on the Linux platforms, as it's needed by RocksDB.
    
    Change-Id: Iba9792a19c559f5d9ff7866564a969da6943b8a3
    Reviewed-on: http://review.couchbase.org/84117
    Reviewed-by: Chris Hillery <ceej@couchbase.com>
    Tested-by: Build Bot <build@couchbase.com>
  2. CBD-2127: Fix rpath for zlib on macOS

    Kenneth Lareau committed Oct 6, 2017
    Use install_name_tool to set the rpath for zlib on macOS to @rpath,
    instead of having a hardcoded path.
    
    Change-Id: I075fb89575b0362a3e1d03dde596a911b4bc04cd
    Reviewed-on: http://review.couchbase.org/84113
    Reviewed-by: Chris Hillery <ceej@couchbase.com>
    Tested-by: Kenneth Lareau <kenneth.lareau@couchbase.com>
  3. MB-25866: Bump jemalloc build number to pick up additional code change

    ceejatec committed Oct 6, 2017
    Change-Id: I47d7a707101f85530bddeeca2821f72bff7eca86
    Reviewed-on: http://review.couchbase.org/84114
    Tested-by: Build Bot <build@couchbase.com>
    Reviewed-by: Chris Hillery <ceej@couchbase.com>
  4. MB-26221 [2/2] [RocksDB] Use the new Snappy-enabled library

    paolococchi committed with daverigby Oct 3, 2017
    With this change we start using the new RocksDB library that enables
    compression with Snappy.
    
    Change-Id: I094b0933268445fae6fc988825b0a8dc68a420a8
    Reviewed-on: http://review.couchbase.org/83958
    Tested-by: Build Bot <build@couchbase.com>
    Reviewed-by: Dave Rigby <daver@couchbase.com>
  5. MB-26221 [1/2] [RocksDB] Enable Snappy compression

    paolococchi committed with daverigby Oct 3, 2017
    RocksDB uses Snappy compression by default if Snappy is linked to the
    RocksDB library. With this change we link Snappy when we build RocksDB.
    
    Note that rocksdb is now the second cbdep package to require Snappy as
    a dependancy (after python-snappy). As such, it is necessary to bypass
    the normal check of only downloading and installing a dep once; as
    both rocksdb and python-snappy need to have snappy downloaded and
    extracted into their respective build directories.
    
    Change-Id: I8b59f7a39003f8b4735876f5a3045da5ff63bf9c
    Reviewed-on: http://review.couchbase.org/83957
    Reviewed-by: Chris Hillery <ceej@couchbase.com>
    Tested-by: Build Bot <build@couchbase.com>
    Tested-by: Dave Rigby <daver@couchbase.com>
Commits on Oct 5, 2017
  1. MB-26279: Ignore v8 compiler type cache

    melkote committed Oct 5, 2017
    Change-Id: I1ac21a6bbec59c37a808ca14d3b848ce8afc518e
    Reviewed-on: http://review.couchbase.org/84070
    Tested-by: Build Bot <build@couchbase.com>
    Reviewed-by: Sriram Melkote <siri@couchbase.com>
  2. Update documentation for running code coverage reports

    eugen-virtan committed with daverigby Oct 5, 2017
    Update the documentation to include the correct function call and
    add a couple of useful notes.
    
    Change-Id: I8aa09da6044ed824f86b0875279ff01d29d08ee4
    Reviewed-on: http://review.couchbase.org/84058
    Tested-by: Build Bot <build@couchbase.com>
    Reviewed-by: Dave Rigby <daver@couchbase.com>
Commits on Oct 3, 2017
  1. MB-26187: Remove DT_RUNPATH from libv8

    ceejatec committed with Aman Kishore Achpal Oct 3, 2017
    Change-Id: Ie7872570223c5f4cded9e0a52dfa452fced71bd4
    Reviewed-on: http://review.couchbase.org/83951
    Tested-by: Build Bot <build@couchbase.com>
    Reviewed-by: Aman Kishore Achpal <aman.achpal@couchbase.com>
Commits on Sep 29, 2017
  1. MB-25866: Change built jemalloc to 4.3.1-couchbase1

    ceejatec committed Sep 29, 2017
    4.3.1-couchbase1 adds a single backported fix to yield in
    spin_adaptive: jemalloc/jemalloc@de8a68e
    
    Also ensure that Windows build fails if attempted, as we do not have
    build automation there yet.
    
    Change-Id: Ia73a455f54e54d04ebebec35086b1144413c6d36
    Reviewed-on: http://review.couchbase.org/83872
    Tested-by: Build Bot <build@couchbase.com>
    Reviewed-by: Chris Hillery <ceej@couchbase.com>
  2. Build libevent with OpenSSL support

    trondn committed Sep 29, 2017
    We want to be able to move the code in memcached over to
    using the bufferevent methods in libevent, and at the same
    time get rid of most of the SSL related code in memcached
    (as there is a bufferevent layer which may do this for us
    for "free")
    
    Change-Id: I2a8fee8be17762d43f45388cfb9b9b7a161c036c
    Reviewed-on: http://review.couchbase.org/83865
    Reviewed-by: Chris Hillery <ceej@couchbase.com>
    Tested-by: Build Bot <build@couchbase.com>
  3. Search for libevent_openssl for non-supported platforms

    trondn committed Sep 29, 2017
    The cmake version of libevent builds only two libraries,
    but the automake version of libevent builds a separate
    libevent_openssl library. Add that library if it exists
    and is in the same directory as libevent_core.
    
    Change-Id: Ic955ca088d25a2717da5668cbae197584316c638
    Reviewed-on: http://review.couchbase.org/83863
    Tested-by: Build Bot <build@couchbase.com>
    Reviewed-by: Chris Hillery <ceej@couchbase.com>
  4. Report the correct name for the libevent_pthread library

    trondn committed Sep 29, 2017
    The copy'n'paste moster made us report the name of the
    extras library twice instead of the pthread one.
    
    Change-Id: Ia6570e53c5e2c7e3db852456a7ca066505f859a8
    Reviewed-on: http://review.couchbase.org/83862
    Reviewed-by: Chris Hillery <ceej@couchbase.com>
    Tested-by: Build Bot <build@couchbase.com>
Commits on Sep 28, 2017
  1. CBD-2119: Upgrade jemalloc to 5.0.1 for Unix/macOS

    Kenneth Lareau committed Sep 28, 2017
    Change-Id: I951d5e3bbef03950f3d3139451d32e317c378763
    Reviewed-on: http://review.couchbase.org/83791
    Tested-by: Build Bot <build@couchbase.com>
    Reviewed-by: Chris Hillery <ceej@couchbase.com>
Commits on Sep 27, 2017
  1. CBD-2113: Ensure zlib include and lib paths are found by top-level CM…

    Kenneth Lareau committed Sep 27, 2017
    …akeLists.txt
    
    Change-Id: Ia610cfdb104067a3af9ded13038efd43abd1a254
    Reviewed-on: http://review.couchbase.org/83785
    Reviewed-by: Chris Hillery <ceej@couchbase.com>
    Tested-by: Build Bot <build@couchbase.com>
  2. MB-26158 [2/2] [RocksDB] Use the new portable shared library

    paolococchi committed with trondn Sep 27, 2017
    With this change we set the new portable RocksDB library as dependency
    for kv-engine.
    
    Change-Id: Iabc69a11b52209d132dd8aea54ec7eddc54decf5
    Reviewed-on: http://review.couchbase.org/83770
    Tested-by: Build Bot <build@couchbase.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
  3. CBD-2102: flex - fix @rpath on MacOS; add Windows build (gnuwin32)

    ceejatec committed Sep 27, 2017
    Change-Id: I7f4bfa3cc19437355d0f8bdd016847ce89b94244
    Reviewed-on: http://review.couchbase.org/83768
    Reviewed-by: Kenneth Lareau <kenneth.lareau@couchbase.com>
    Tested-by: Build Bot <build@couchbase.com>
  4. MB-26158 [1/2] [RocksDB] Build a portable shared library

    paolococchi committed with trondn Sep 25, 2017
    We currently build the RocksDB library with the default settings. This
    makes the compiler to use the AVX Instrunction Set, which is not
    supported by all CPUs.
    With this change we build RocksDB with the option `PORTABLE=1` that
    avoids AVX.
    
    Change-Id: Ief16dd5b074dd529fc5b106fd22810a8651e65fb
    Reviewed-on: http://review.couchbase.org/83681
    Reviewed-by: Dave Rigby <daver@couchbase.com>
    Tested-by: Build Bot <build@couchbase.com>
    Reviewed-by: Trond Norbye <trond.norbye@gmail.com>
  5. Update CMAKE_PREFIX_PATH to include cbdeps prefix paths

    Kenneth Lareau committed Sep 27, 2017
    Change-Id: I989d5360a76ec7af045af4b960400be848ae2b1e
    Reviewed-on: http://review.couchbase.org/83763
    Reviewed-by: Chris Hillery <ceej@couchbase.com>
    Tested-by: Build Bot <build@couchbase.com>
Commits on Sep 26, 2017
  1. Remove suppression rule for drain_notification_channel

    eugen-virtan committed with daverigby Sep 25, 2017
    This data race has been addressed in MB-25700 and as such, the
    suppression rule is no longer needed.
    
    Change-Id: I92936237f122f174ac5e8cd62f57b9556c498db2
    Reviewed-on: http://review.couchbase.org/83680
    Tested-by: Build Bot <build@couchbase.com>
    Reviewed-by: Dave Rigby <daver@couchbase.com>
  2. Enable eventing project

    melkote committed Sep 25, 2017
    Change-Id: I9b1da66cc2ba3b33c56d7b153360deeed8392be8
    Reviewed-on: http://review.couchbase.org/83705
    Tested-by: Sriram Melkote <siri@couchbase.com>
    Tested-by: Build Bot <build@couchbase.com>
    Reviewed-by: Sriram Melkote <siri@couchbase.com>
Commits on Sep 25, 2017
  1. CBD-2117: Bump libcouchbase to -cb6

    ceejatec committed Sep 25, 2017
    No changes in code or packaging, but unfortunately many builders cached
    a previous incorrect -cb5 testing build and this is the only way to
    get things unstuck.
    
    Change-Id: Ia6928fc232ee2687883690cf6fc260a61a73d7e4
    Reviewed-on: http://review.couchbase.org/83696
    Tested-by: Build Bot <build@couchbase.com>
    Reviewed-by: Chris Hillery <ceej@couchbase.com>
  2. CBD-2117: Fix packaging of libcouchbase .so files

    ceejatec committed Sep 25, 2017
    Change-Id: I28dc6d17f7b389401dd6dca055a17ff4f90e6a6c
    Reviewed-on: http://review.couchbase.org/83672
    Tested-by: Build Bot <build@couchbase.com>
    Reviewed-by: Chris Hillery <ceej@couchbase.com>
Commits on Sep 22, 2017
  1. CBD-2054: Ensure Win64 build for libcouchbase

    ceejatec committed Sep 22, 2017
    Change-Id: I914117a9ab6032a57b5615aaa58af64d1ddca45c
    Reviewed-on: http://review.couchbase.org/83633
    Reviewed-by: Chris Hillery <ceej@couchbase.com>
    Tested-by: Chris Hillery <ceej@couchbase.com>
  2. CBD-2055: Build libuv as x64 on Windows

    ceejatec committed Sep 22, 2017
    Change-Id: Iade958e3db1e05a05f9902121ccde15bdd42799d
    Reviewed-on: http://review.couchbase.org/83625
    Tested-by: Build Bot <build@couchbase.com>
    Reviewed-by: Chris Hillery <ceej@couchbase.com>
Commits on Sep 21, 2017
  1. CBD-2113: Add zlib as a cbdep

    Kenneth Lareau committed Sep 21, 2017
    This initial change should cover all platforms, including Windows
    
    Change-Id: Ib5ae8714197328bb24247ba3c10d053a21c1178d
    Reviewed-on: http://review.couchbase.org/83586
    Reviewed-by: Chris Hillery <ceej@couchbase.com>
    Tested-by: Build Bot <build@couchbase.com>
Commits on Sep 20, 2017
  1. Correct libuv packaging on Windows

    ceejatec committed Sep 20, 2017
    Also don't look for libuv libraries in _exploded_dir; we want to only
    find them in the target install directory (unlike headers).
    
    Change-Id: Ic20fb939b38aa5264bf393ac045da4d3f80c98b0
    Reviewed-on: http://review.couchbase.org/83534
    Tested-by: Build Bot <build@couchbase.com>
    Reviewed-by: Chris Hillery <ceej@couchbase.com>
  2. Correct libcouchbase packaging on Windows

    ceejatec committed Sep 20, 2017
    Also don't look for libcouchbase libraries in _exploded_dir; we want to only
    find them in the target install directory (unlike headers).
    
    Change-Id: Ie109a7c9d4f3bcce9b61a0617f8e375c34f711cd
    Reviewed-on: http://review.couchbase.org/83535
    Tested-by: Build Bot <build@couchbase.com>
    Reviewed-by: Chris Hillery <ceej@couchbase.com>
  3. CBD-2102: Bump flex to -cb2 to pick up packaging change

    ceejatec committed Sep 20, 2017
    Change-Id: I21cfe6d260533857f3520188c695a0b2ba442d32
    Reviewed-on: http://review.couchbase.org/83542
    Tested-by: Build Bot <build@couchbase.com>
    Reviewed-by: Chris Hillery <ceej@couchbase.com>
  4. Quick fix for build breakage

    ceejatec committed Sep 20, 2017
    Change-Id: I15f2787d8463ce5eb1b712ed0b6e05ec9f7d03a8
    Reviewed-on: http://review.couchbase.org/83541
    Reviewed-by: Chris Hillery <ceej@couchbase.com>
    Tested-by: Chris Hillery <ceej@couchbase.com>
  5. CBD-2102: Add flex to cbdeps

    Kenneth Lareau committed Sep 20, 2017
    Initial runthrough without proper Windows support.
    
    Change-Id: I61b45a8c18e7cadf31c03fdf03c56f9074cccd80
    Reviewed-on: http://review.couchbase.org/83516
    Reviewed-by: Kenneth Lareau <kenneth.lareau@couchbase.com>
    Tested-by: Kenneth Lareau <kenneth.lareau@couchbase.com>