From d022c3c42128864a2fb72d375c93289683789a55 Mon Sep 17 00:00:00 2001 From: shruti-14 Date: Thu, 27 Jun 2024 17:05:30 +0530 Subject: [PATCH] Removed default props as it is no more supported --- .../DefinitionTooltip/DefinitionTooltip.js | 22 ++++++++----------- src/lib/components/TextInput/TextInput.js | 19 ++++++---------- src/lib/components/Tooltip/Tooltip.js | 9 ++------ 3 files changed, 18 insertions(+), 32 deletions(-) diff --git a/src/lib/components/DefinitionTooltip/DefinitionTooltip.js b/src/lib/components/DefinitionTooltip/DefinitionTooltip.js index 2209099..19ffb42 100644 --- a/src/lib/components/DefinitionTooltip/DefinitionTooltip.js +++ b/src/lib/components/DefinitionTooltip/DefinitionTooltip.js @@ -30,7 +30,7 @@ import positionTooltip from "../../helpers/positionTooltip.js"; url [String] - A url to link to. Will take precedence over onClick. */ -const DefinitionTooltip = props => { +const DefinitionTooltip = (props) => { const { classes, definition, @@ -38,16 +38,16 @@ const DefinitionTooltip = props => { id, link, onClick, - position, + position = "top", term, - url + url, } = props; const tooltipElementId = `${id}-desc`; const tooltipRef = useRef(null); const triggerClass = classnames("dfn-tooltip-trigger", classes); - const handleMouseEnter = event => { + const handleMouseEnter = (event) => { const currentTooltip = tooltipRef.current; positionTooltip(currentTooltip, position); }; @@ -68,7 +68,7 @@ const DefinitionTooltip = props => { aria-labelledby={tooltipElementId} className={triggerClass} dangerouslySetInnerHTML={{ - __html: term + __html: term, }} href={url} onMouseEnter={handleMouseEnter} @@ -82,7 +82,7 @@ const DefinitionTooltip = props => { aria-labelledby={tooltipElementId} className={triggerClass} dangerouslySetInnerHTML={{ - __html: term + __html: term, }} onClick={onClick} onMouseEnter={handleMouseEnter} @@ -100,7 +100,7 @@ const DefinitionTooltip = props => { > @@ -118,7 +118,7 @@ const DefinitionTooltip = props => { >

${term}: ${definition}` + __html: `${term}: ${definition}`, }} id={`${id}-definition`} /> @@ -134,10 +134,6 @@ const DefinitionTooltip = props => { ); }; -DefinitionTooltip.defaultProps = { - position: "top" -}; - DefinitionTooltip.propTypes = { classes: PropTypes.string, definition: PropTypes.string.isRequired, @@ -147,7 +143,7 @@ DefinitionTooltip.propTypes = { onClick: PropTypes.func, position: PropTypes.oneOf(["bottom", "left", "right", "top"]), term: PropTypes.string.isRequired, - url: PropTypes.string + url: PropTypes.string, }; export default DefinitionTooltip; diff --git a/src/lib/components/TextInput/TextInput.js b/src/lib/components/TextInput/TextInput.js index 179fb75..e7cea05 100644 --- a/src/lib/components/TextInput/TextInput.js +++ b/src/lib/components/TextInput/TextInput.js @@ -59,7 +59,7 @@ import classnames from "classnames"; const TextInput = React.forwardRef((props, ref) => { const { autoComplete, - autoFocus, + autoFocus = false, classes, disabled, feedbackContext, @@ -79,22 +79,22 @@ const TextInput = React.forwardRef((props, ref) => { placeholder, polite, readOnly, - required, + required = false, step, type, - value + value, } = props; const controlClasses = classnames("text", "control", classes, { disabled: disabled, inline: inline, - invalid: isValid !== undefined && !isValid + invalid: isValid !== undefined && !isValid, }); const feedbackClasses = classnames( "control-feedback", `${feedbackContext || "error"}`, { - "visually-hidden": !feedbackText + "visually-hidden": !feedbackText, } ); const feedbackId = `${id}-feedback`; @@ -191,14 +191,9 @@ TextInput.propTypes = { "text", "time", "url", - "week" + "week", ]), - value: PropTypes.string -}; - -TextInput.defaultProps = { - autoFocus: false, - required: false + value: PropTypes.string, }; export default TextInput; diff --git a/src/lib/components/Tooltip/Tooltip.js b/src/lib/components/Tooltip/Tooltip.js index 90ef5c7..47ab425 100644 --- a/src/lib/components/Tooltip/Tooltip.js +++ b/src/lib/components/Tooltip/Tooltip.js @@ -38,11 +38,11 @@ const Tooltip = (props) => { id, link, onClick, - position, + position = "top", text, tooltipBody, url, - buttonType + buttonType = "button", } = props; const tooltipElementId = `${id}-desc`; @@ -119,11 +119,6 @@ const Tooltip = (props) => { ); }; -Tooltip.defaultProps = { - position: "top", - buttonType: "button" -}; - Tooltip.propTypes = { classes: PropTypes.string, tooltipBody: PropTypes.string.isRequired,