Ultra low latency mode #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aylists and segments. Fallback to MPEG-TS demuxer
…e the playback starts as fast as possible in ultra low latency mode
FelonEkonom
reviewed
Nov 12, 2025
lib/ex_hls/client/live/reader.ex
Outdated
| forwarder: forwarder, | ||
| segment_format: segment_format | ||
| segment_format: segment_format, | ||
| ultra_low_latency?: ultra_low_latency? |
Member
There was a problem hiding this comment.
For me this option name can be confused with LL-HLS, so I'd rename it to something more different
Collaborator
Author
There was a problem hiding this comment.
how about live_edge_mode?
FelonEkonom
approved these changes
Nov 17, 2025
lib/ex_hls/client/live/reader.ex
Outdated
Comment on lines
112
to
114
| defp should_start_playing?(%{live_edge_mode?: true}) do | ||
| true | ||
| end |
Member
There was a problem hiding this comment.
let's move usage of live_edge_mode? filed into or statement in the next function clause
lib/ex_hls/client/live/reader.ex
Outdated
| end | ||
|
|
||
| defp next_segment_to_download_seq_num(%{max_downloaded_seq_num: nil} = state) do | ||
| # in the ultra low latency mode it skips to the most recent segment |
lib/ex_hls/client.ex
Outdated
| the client will treat HLS segments based on the extension in their name, | ||
| falling back `MPEG-TS` if the cannot recognize the extension. | ||
| Passing `live_edge_mode?: true` option turns on ultra low latency mode of the client. |
Member
There was a problem hiding this comment.
ultra low latency mode - it is now live edge mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
ultra_low_latency?option to the Client which allows for turning on the ultra low latency modeThe ultra low latency mode:
Closes membraneframework/membrane_core#1018