Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow loading sps and pps values before sending frames #7
+19
−2
Conversation
This comment has been minimized.
This comment has been minimized.
|
This fixes #6 |
| defp maybe_decode(nil, _decoder_ref), do: :ok | ||
|
|
||
| defp maybe_decode(data, decoder_ref) do | ||
| # ignore return of this function as ffpmeg treats it as an error. |
This comment has been minimized.
This comment has been minimized.
mat-hek
Jan 28, 2020
•
Member
Maybe waiting for the first buffer and prepending the parameter sets when it comes in would help avoid that error?
This comment has been minimized.
This comment has been minimized.
ConnorRigby
Jan 28, 2020
Author
Contributor
You're correct. I just tested that out, and it removes the error. Will update the PR
This comment has been minimized.
This comment has been minimized.
ConnorRigby
Jan 28, 2020
Author
Contributor
@mat-hek i've updated the PR. Let me know what you think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ConnorRigby commentedJan 27, 2020
No description provided.