Skip to content
GitHub no longer supports this web browser. Learn more about the browsers we support.
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow loading sps and pps values before sending frames #7

Merged
merged 1 commit into from Jan 29, 2020

Conversation

@ConnorRigby
Copy link
Contributor

ConnorRigby commented Jan 27, 2020

No description provided.

@ConnorRigby

This comment has been minimized.

Copy link
Contributor Author

ConnorRigby commented Jan 27, 2020

This fixes #6

defp maybe_decode(nil, _decoder_ref), do: :ok

defp maybe_decode(data, decoder_ref) do
# ignore return of this function as ffpmeg treats it as an error.

This comment has been minimized.

Copy link
@mat-hek

mat-hek Jan 28, 2020

Member

Maybe waiting for the first buffer and prepending the parameter sets when it comes in would help avoid that error?

This comment has been minimized.

Copy link
@ConnorRigby

ConnorRigby Jan 28, 2020

Author Contributor

You're correct. I just tested that out, and it removes the error. Will update the PR

This comment has been minimized.

Copy link
@ConnorRigby

ConnorRigby Jan 28, 2020

Author Contributor

@mat-hek i've updated the PR. Let me know what you think.

@mat-hek mat-hek merged commit b8ca7dd into membraneframework:master Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.