Extend test CA validity to 2049 #725
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! interesting change. can you also update t/README-TLS.md - which includes instructions on re-generating the files? A note for why they're used for so long would be best too |
bmwiedemann
force-pushed
the
ftbfs2025
branch
from
e3bfe9c
to
c2701fd
Compare
|
I updated the README-TLS and used the commands to create certs with 500y validity. My tests showed that every test now passes in 2035 (both x86_64 and i586). |
below is a diff of certtool -i
Root Certificate Authority
Validity:
- Not Before: Thu May 14 22:11:49 UTC 2020
- Not After: Tue May 13 22:11:49 UTC 2025
+ Not Before: Tue Oct 27 03:04:55 UTC 2020
+ Not After: Fri Jun 28 03:04:55 UTC 2520
This PR was done while working on reproducible builds for openSUSE.
bmwiedemann
force-pushed
the
ftbfs2025
branch
from
c2701fd
to
56e7619
Compare
|
No complaints! merged this up for the next release. Thanks for taking the time. |
|
released in 1.6.9! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Extend test CA validity to 2049
so that tests do not fail after 2025
Background:
As part of my work on reproducible builds for openSUSE, I check that software still gives identical build results in the future.
The usual offset is +15 years, because that is how long I expect some software will be used in some places.
This showed up failing tests in our memcached package build tests.
Tests failed thus:
Below is a diff of
certtool -iRoot Certificate Authority Validity: - Not Before: Thu May 14 22:11:49 UTC 2020 - Not After: Tue May 13 22:11:49 UTC 2025 + Not Before: Sat Oct 10 17:49:30 UTC 2020 + Not After: Fri Dec 31 17:49:32 UTC 2049This PR was done while working on reproducible builds for openSUSE.