Random improvements #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mainly fixing documentation, adhering to MediaWiki code conventions, etc. Left a few @fixme's where I saw things that didn't look right but wasn't sure on how to fix them.
| @@ -141,7 +132,7 @@ public static function onImageBeforeProduceHTML( | |||
|
|
|||
| if ( self::$oldIDSet == true ) { | |||
| $history = $file->getHistory( | |||
| $limit = 1, $start = $articleDatetime); | |||
| /* $limit = */ 1, /* $start = */ $articleDatetime); // @fixme undefined variable | |||
There was a problem hiding this comment.
I'm glad you found this. It should be self::$articleDatetime as set earlier by the onArticleViewHeader hook. I'm embarrassed this made it into the released version. Good thing I marked the TimeNegotiationForThumbnails option as EXPERIMENTAL.
shawnmjones
pushed a commit
that referenced
this pull request
Jun 17, 2014
Random improvements, follow on commit coming afterwards to make some additional improvements based on this input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly fixing documentation, adhering to MediaWiki code conventions, etc.
Left a few @fixme's where I saw things that didn't look right but wasn't sure on how to fix them.