Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visibility of text selection handlers #533

Merged
merged 4 commits into from Oct 19, 2021
Merged

Visibility of text selection handlers #533

merged 4 commits into from Oct 19, 2021

Conversation

amantoux
Copy link
Collaborator

Fixes #530

@amantoux amantoux marked this pull request as draft September 17, 2021 07:33
@amantoux amantoux marked this pull request as ready for review September 17, 2021 07:34
@amantoux amantoux marked this pull request as draft September 17, 2021 07:34
pulyaevskiy
pulyaevskiy reviewed Sep 20, 2021
View reviewed changes
Copy link
Contributor

@pulyaevskiy pulyaevskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I did first pass there and left some comments. Please take a look!

packages/zefyr/lib/src/rendering/editor.dart Outdated Show resolved Hide resolved
packages/zefyr/lib/src/rendering/editor.dart Show resolved Hide resolved
packages/zefyr/lib/src/rendering/editor.dart Show resolved Hide resolved
packages/zefyr/lib/src/widgets/single-child-scroll-view.dart Outdated Show resolved Hide resolved
packages/zefyr/lib/src/widgets/single-child-scroll-view.dart Outdated Show resolved Hide resolved
packages/zefyr/lib/src/widgets/single-child-scroll-view.dart Outdated Show resolved Hide resolved
@amantoux amantoux marked this pull request as ready for review September 23, 2021 05:04
pulyaevskiy
pulyaevskiy requested changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@pulyaevskiy pulyaevskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this approach looks good. I just have one suggestion to make it a bit more concise. PTAL

packages/zefyr/lib/src/widgets/single_child_scroll_view.dart Outdated Show resolved Hide resolved
pulyaevskiy
pulyaevskiy approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@pulyaevskiy pulyaevskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again!

@pulyaevskiy pulyaevskiy merged commit ce5d2ab into memspace:1.0-dev Oct 19, 2021
@amantoux amantoux deleted the handles_visibility branch October 30, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pulyaevskiy pulyaevskiy pulyaevskiy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amantoux @pulyaevskiy