Skip to content

chore: pwt update#2252

Merged
r0b1n merged 4 commits into
mainfrom
feat/pwt-11.11
Jun 9, 2026
Merged

chore: pwt update#2252
r0b1n merged 4 commits into
mainfrom
feat/pwt-11.11

Conversation

@r0b1n

@r0b1n r0b1n commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

r0b1n added 2 commits June 8, 2026 15:49
@r0b1n r0b1n force-pushed the feat/pwt-11.11 branch from b3f5110 to 34be645 Compare June 8, 2026 13:49
@github-actions

This comment has been minimized.

@r0b1n r0b1n force-pushed the feat/pwt-11.11 branch from 34be645 to 1f87d23 Compare June 8, 2026 14:08
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

AI Code Review

⚠️ Approved with suggestions — low-severity items only, safe to merge


What was reviewed

File Change
package.json Bumps @mendix/pluggable-widgets-tools override from 11.8.011.11.0; removes several security/compat overrides now handled upstream
patches/@mendix__pluggable-widgets-tools.patch Replaces the old SCSS/jest patch with a single change: disables checkNodeVersion() in bin/mx-scripts.js
packages/pluggableWidgets/date-time-picker-web/src/ui/DateTimePicker.scss Replaces calc-size(auto, size) with height: auto in :popover-open rule
pnpm-lock.yaml Lockfile update reflecting PWT 11.11.0, rollup 3→4, jest 29→30, sass 1.93→1.100
packages/pluggableWidgets/*/typings/*.d.ts Import-order regeneration only (auto-generated, no logic change)
packages/pluggableWidgets/**/__snapshots__/*.snap Snapshot header URL updated goo.gljestjs.io; no assertion changes

Skipped (out of scope): pnpm-lock.yaml (lockfile), typings/*.d.ts (generated), __snapshots__/*.snap (auto-generated)


Findings

⚠️ Low — Wildcard rollup specifier in automation package

File: pnpm-lock.yaml (automation importer, two occurrences)
Note: The rollup specifier changed from the pinned '3.29' to '*', which resolved to 4.61.1 at lock time. The lockfile pins the resolved version, so this is safe for reproducible installs. However, a wildcard * means a future pnpm update could silently upgrade to a breaking rollup 5.x. Consider pinning to '^4' or '4' rather than '*' to keep the intent explicit.


⚠️ Low — checkNodeVersion() disabled silently via patch

File: patches/@mendix__pluggable-widgets-tools.patch line 7
Note: The comment // Disabled via pnpm patch explains that it is disabled, but not why. If this is needed because the new PWT version enforces a Node version that conflicts with the repo's .nvmrc / CI image, that constraint should be documented (e.g. a brief note in the patch file or a follow-up ticket) so it is not accidentally re-enabled or left indefinitely. If the intent is to remove this permanently, consider opening an upstream issue.


Positives

  • Old patch hunks (silenceDeprecations, collectCoverage comment-out) that were previously workarounds are now cleanly removed — the new PWT version apparently resolves those issues upstream, which is the right outcome.
  • The SCSS fix replacing calc-size(auto, size) with height: auto is correct: calc-size() has very limited browser support and removing it avoids a Sass deprecation warning in newer sass 1.100.
  • Security overrides that are no longer needed (decode-uri-component, json5, loader-utils, minimatch) are cleaned up rather than left to rot — good hygiene.
  • Snapshot header URL updates (goo.gljestjs.io) confirm tests were actually re-run against the new jest 30 toolchain, not just rebased.

@r0b1n r0b1n merged commit 6a920b9 into main Jun 9, 2026
21 of 22 checks passed
@r0b1n r0b1n deleted the feat/pwt-11.11 branch June 9, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment