Skip to content

Conversation

@r0b1n
Copy link
Collaborator

@r0b1n r0b1n commented Apr 18, 2023

Pull request type

Bug fix (non-breaking change which fixes an issue)


Description

Monitor active element and apply latest seen value when user leaves Rich Text widget.

What should be covered while testing?

Rich text still:

  • saves the data with debounce while typing
  • saves data immediately when leaving the field
  • doesn't give any errors when leaving page with rich text
  • multiple editors work on the same page correctly and don't conflict
  • On Change action works in both scenarios, in debounced change and in immediate change.

@r0b1n r0b1n requested a review from a team as a code owner April 18, 2023 08:43
@r0b1n r0b1n force-pushed the wc1778/rich-text branch from 188f69f to 1366c55 Compare April 18, 2023 09:46
Copy link
Collaborator

@iobuhov iobuhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rahmanunver rahmanunver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works as intended!

@r0b1n r0b1n merged commit 2eb87fc into main Apr 18, 2023
@r0b1n r0b1n deleted the wc1778/rich-text branch April 18, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants