Skip to content

[WC-1328]: HTMLElement pre release updates #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iobuhov merged 7 commits into from
Nov 21, 2022
Merged

[WC-1328]: HTMLElement pre release updates #62

iobuhov merged 7 commits into from
Nov 21, 2022

Conversation

@iobuhov
Copy link
Collaborator

@iobuhov iobuhov commented Nov 15, 2022 •
edited
Loading

Description

This is small changes, you may read "widget polishing" before v1 release.

Pull request type

  • No code changes (changes to documentation, CI, metadata, etc)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Test related change (New E2E test, test automation, etc.)

What should be covered while testing?

We need to test:

  • Page Explorer custom caption
  • Design preview in "repeat" and "no repeat" modes
  • Structure preview in "repeat" and "no repeat" modes
  • Icons in light/dark theme
  • Dropzone header (in repeat mode) should be hidden in 9.20

@iobuhov iobuhov requested a review from a team as a code owner November 15, 2022 16:10
rahmanunver
rahmanunver previously approved these changes Nov 16, 2022
View reviewed changes
@iobuhov iobuhov force-pushed the WC-1328/small-html-element-updates branch from ccf2840 to 74cd9ba Compare November 17, 2022 13:49
leonardomendix
leonardomendix previously approved these changes Nov 17, 2022
View reviewed changes
@iobuhov iobuhov merged commit 53543ce into main Nov 21, 2022
@iobuhov iobuhov deleted the WC-1328/small-html-element-updates branch November 21, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rahmanunver rahmanunver rahmanunver approved these changes

@leonardomendix leonardomendix leonardomendix approved these changes

Assignees

No one assigned

Labels

html-element-web pluggable-widgets-commons

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iobuhov @rahmanunver @leonardomendix