Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use enum for keys, not plain strings #51

Closed
edekhayser opened this issue Apr 5, 2015 · 2 comments
Closed

Use enum for keys, not plain strings #51

edekhayser opened this issue Apr 5, 2015 · 2 comments

Comments

@edekhayser
Copy link

Using these magic keywords is not very extensible or easy to use. Having predefined constants would be a step up, but you can even do better with an enum for all the animation options. If you wanted, you could use these strings to define the enum values in the inner workings not to break the current code.

@MengTo
Copy link
Owner

MengTo commented Apr 6, 2015

I agree, we'll think of something.

@schneiderandre
Copy link
Contributor

It seems that this is a duplicate of #22. @edekhayser If you agree, we can close this issue and continue the discussion there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants