Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
warp_to_mask, warp_to_shape, fast resizing of images #369
This PR changes the warping interface in Menpo.
We've always had
Unfortunately, this wasn't well tested, and suffered from a number of shortcomings:
This PR fixes this by splitting warp_to into two methods -
Instead of taking a template mask this variant takes a template shape. This matches exactly the interface to
The work isn't quite done, but I wanted to put this up to get feedback. Still outstanding we have
I had a look at the test failing here...
In my mac:
I don't know what's causing this and I'm not sure is relevant... AAMs on my notebooks seemed to function well ;-)
On another note, Travis is telling us we've got a possible division by 0 on the
@jalabort it's not surprising that we might get slight numerical differences - if you are happy with the performance I say we get it in! It's only been 109 days since I put this PR up ;)
Are we happy with the change to importing
As for the errors they have been around for a little while, I'll make an issue to track it, thanks!
@patricksnape has discovered that skimage's warp method (which this PR relies on) is very opinionated about the range of allowable outputs - namely that it clips them to [0 - 1]. This may explain the few numerical differences we are seeing.
This PR will need to be adapted to use a modified version of the scikit image warp function before we bring it in.