New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG fixed: block element not reset if norm=0 #382

Merged
merged 1 commit into from Jul 2, 2014

Conversation

Projects
None yet
5 participants
@jabooth
Member

jabooth commented Jun 9, 2014

In HOGS we calculate a norm per block and then use this norm to normalize the block itself.

We currently fail to deal with the case where the norm is 0. As the underlying memory is dirty, this leads to possible bugs.

We can imagine that for a given value of (x, y), block[i][j][k] is modified at line 426
But that for another value (after) (x', y'), block[i][j][k] is not modified (no else statement)
That means that the value of block[i][j][k] will not be the one corresponding to this (x', y') (and not 0.) but will still be taken into account for the remaining part of the process.

Credit to @dubzzz for finding and fixing this!

@jabooth

This comment has been minimized.

Member

jabooth commented Jun 24, 2014

Is everyone happy for this to go in? @nontas?

@jalabort

This comment has been minimized.

Member

jalabort commented Jun 25, 2014

I'm happy with it.

As discussed, maybe it'd be good to report this back to the guys who originally coded it...

@nontas

This comment has been minimized.

Member

nontas commented Jun 30, 2014

Sorry for the very late reply.
Yes, I think this is the correct way to compute it.
And yes I think it should be reported back to the author(s).
+1

@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Jul 2, 2014

+1

patricksnape added a commit that referenced this pull request Jul 2, 2014

Merge pull request #382 from dubzzz/hog_bug
BUG fixed: block element not reset if norm=0

@patricksnape patricksnape merged commit 3e12043 into menpo:master Jul 2, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment