New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bunch of Python 3 compatibility fixes #399

Merged
merged 4 commits into from Jul 19, 2014

Conversation

Projects
None yet
2 participants
@jabooth
Member

jabooth commented Jul 18, 2014

Nothing crazy, just some syntactic changes that make Menpo more compatible with Python 3 (without sacrificing anything).

jabooth added some commits Jul 18, 2014

@jabooth

This comment has been minimized.

Member

jabooth commented Jul 18, 2014

This PR is all of the issues flagged up by:

2to3 -x xrange -x metaclass -x future -x dict -x zip -w -n ./menpo

This means we are knowingly ignoring the metaclass syntax change, xrange()/iteritems()/zip() iterator stuff and __future__ as all this stuff would break or change the performance of what we currently have. There were a few other standard library changes that I opted to ignore as they would also be breaking changes.

@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Jul 19, 2014

+1 looks good to me

jabooth added a commit that referenced this pull request Jul 19, 2014

Merge pull request #399 from jabooth/py3
bunch of Python 3 compatibility fixes

@jabooth jabooth merged commit 71dc0e6 into menpo:master Jul 19, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@jabooth jabooth deleted the jabooth:py3 branch Aug 26, 2014

@jabooth jabooth referenced this pull request Aug 28, 2014

Closed

Python 3 support #419

4 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment