New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dogfood landmark_resolver in menpo.io #401

Merged
merged 4 commits into from Jul 23, 2014

Conversation

Projects
None yet
2 participants
@jabooth
Member

jabooth commented Jul 23, 2014

landmark_resolver is currently a special case which leads to duplication of code in the _import method. Not only is this inelegant, but it actually causes us some headaches in dealing with the upcoming removal of the group label from a LandmarkGroup. This dogfoods landmark_resolver with a default resolver for Menpo, that behaves exactly as it does in master now anyway. This also clears the way for the removal of label from LandmarkGroup.

@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Jul 23, 2014

This makes my life easier +1

jabooth added a commit that referenced this pull request Jul 23, 2014

Merge pull request #401 from jabooth/lmioimp
Dogfood landmark_resolver in menpo.io

@jabooth jabooth merged commit 445fab7 into menpo:master Jul 23, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@jabooth jabooth deleted the jabooth:lmioimp branch Jul 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment