New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export_mesh with .OBJ exporter #415

Merged
merged 8 commits into from Aug 27, 2014

Conversation

Projects
None yet
2 participants
@jabooth
Member

jabooth commented Aug 26, 2014

Adds an .OBJ exporter so meshes can be saved out from Menpo.

from numpy.testing import assert_allclose, assert_equal
def test_export_obj_textured():

This comment has been minimized.

@jabooth

jabooth Aug 26, 2014

Member

These are two unit tests I wrote earlier that are pretty brutal (just write out to temp dir). Could you give me a hand making them nicely mocked like the ones above @patricksnape?

@jabooth

This comment has been minimized.

Member

jabooth commented Aug 26, 2014

Little background - needed this for some crunch work for GOSH pre-vacation, now @patricksnape has written the Menpo export framework this is a nice addition!

@jabooth jabooth added the in progress label Aug 27, 2014

@jabooth jabooth self-assigned this Aug 27, 2014

Add export_textured_mesh
Fix the temp tests that james had
@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Aug 27, 2014

OK, happy with this now :) +1

@jabooth

This comment has been minimized.

Member

jabooth commented Aug 27, 2014

@patricksnape we are merge with caution here because of AppVeyor, can we resolve this soon? Even if it's just that we break the webhook for now?

jabooth added some commits Aug 27, 2014

Update base.py
Tiny typo fix
@jabooth

This comment has been minimized.

Member

jabooth commented Aug 27, 2014

Some minor typos fixed, will merge once travis is happy. Thanks @patricksnape!

jabooth added a commit that referenced this pull request Aug 27, 2014

Merge pull request #415 from jabooth/exportobj
export_mesh with .OBJ exporter

@jabooth jabooth merged commit 0f7a6ca into menpo:master Aug 27, 2014

1 of 2 checks passed

continuous-integration/appveyor AppVeyor build failed
Details
continuous-integration/travis-ci The Travis CI build passed
Details

@jabooth jabooth deleted the jabooth:exportobj branch Aug 27, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment