Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
aam.fitter, clm.fitter, sdm.trainer packages #432
I agree from that perspective is weird, but I feel this namespacing is clearer once you are within one of the 3 deformable model packages (AAM, CLM, SDM).
This second proposal is not that controversial... I think it might be better.
The fit-fitmultilevel structure was almost self imposed by the way Menlo was growing when we decided to name the packages that way. Basically because of the difficult relationship between the aam package and the lucas kanade package.
The results was we currently have in menpo. This structure is weird in my opinion cause I have an aam package for which all the algorithms are in another package (fit) but we thought it made sense at the time... The same holds for clm and sdm.
I think that could be better designed, but at the time I really didn't know how to do it. What you're proposing seems reasonable but we ought to decides what do we do with the fit package. I personally would put the clm algorithms and regressors were they belong, the clm and sdm packages and I'm just not sure what to do with Lucas kanade because of its more complex relationship with aams
I actually like your proposal for
I know that this breaks the perception that users should be able to just grab something from
@jalabort no need to rush on the larger issue I've raised here (renaming
added a commit
this pull request
Sep 6, 2014
Sep 6, 2014
1 check passed
I believe that's exactly how it should be, yes!
In my opinion it is much clearer this way.
On 5 Sep 2014 22:32, James Booth firstname.lastname@example.org wrote:
I actually like your proposal for menpo.fit items becoming subpackages of the deformable models. Formalising the whole thing:
I know that this breaks the perception that users should be able to just grab something from menpo.fit.lucaskanade and use it, but it does make the whole package seem much more cohesive - and of course there is nothing to stop people importing LK items from menpo.deformablemodel.aam.lucaskanade. I personally think the trade-off is well worth it.