New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make mayavi an optional dependency #464

Merged
merged 1 commit into from Oct 3, 2014

Conversation

Projects
None yet
1 participant
@jabooth
Member

jabooth commented Oct 3, 2014

Mayavi is not available on Python 3 and is a large cumbersome dependency. Whilst it is great to have for 3D work, it is not used at all whilst working with images in Menpo.

This PR removes mayavi from Menpo as a hard dependency. If a user who doesn't have mayavi installed tries to view a 3D object an ImportError is raised that prints the following error:

mayavi is required for viewing 3D objects (consider 'conda/pip install mayavi')

@jabooth jabooth added the in progress label Oct 3, 2014

@jabooth

This comment has been minimized.

Member

jabooth commented Oct 3, 2014

note that this takes us one step closer to #419

jabooth added a commit that referenced this pull request Oct 3, 2014

Merge pull request #464 from jabooth/mayaviopt
make mayavi an optional dependency

@jabooth jabooth merged commit b385ab7 into menpo:master Oct 3, 2014

1 of 2 checks passed

continuous-integration/appveyor Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci The Travis CI build passed
Details

@jabooth jabooth deleted the jabooth:mayaviopt branch Oct 3, 2014

@jabooth jabooth removed the in progress label Oct 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment