New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove HDF5able making room for h5it #474

Merged
merged 5 commits into from Oct 14, 2014

Conversation

Projects
None yet
1 participant
@jabooth
Member

jabooth commented Oct 13, 2014

hdf5able has no morphed into h5it, a more ambitious generic pickle replacement. In response to this, we:

  1. No longer need HDF5able subclassing in Menpo
  2. No longer need to depend on hdf5able/h5it (we'll strongly promote it, but it shouldn't be forced on users of menpo)
  3. No longer need menpo.io.{save,load} (just pickle/h5it)

This PR removes all traces of hdf5able. A future PR will add back pickle specialisation from serializablecallable, once that has stabilised a little.

@jabooth jabooth added the in progress label Oct 13, 2014

@jabooth

This comment has been minimized.

Member

jabooth commented Oct 14, 2014

now h5it has become somewhat stable at version 0.5.0, I think we should bring this in. Note that this will mean we loose custom feature serialisation, but this functionality was broken anyway. Thoughts @patricksnape?

@jabooth

This comment has been minimized.

Member

jabooth commented Oct 14, 2014

Bringing this in now which does change serialization options going forwards - speak to me if you have any issues!

jabooth added a commit that referenced this pull request Oct 14, 2014

Merge pull request #474 from jabooth/hdf5abletopickle
remove HDF5able making room for h5it

@jabooth jabooth merged commit e1b182f into menpo:master Oct 14, 2014

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci The Travis CI build passed
Details

@jabooth jabooth removed the in progress label Oct 14, 2014

@jabooth jabooth deleted the jabooth:hdf5abletopickle branch Oct 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment