New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix residuals for AAMs #478

Merged
merged 3 commits into from Oct 14, 2014

Conversation

Projects
None yet
4 participants
@patricksnape
Contributor

patricksnape commented Oct 14, 2014

Now AAMs are hardcoded to take the SSD. Also, renamed LSIntensity
to SSD.

Also, removed the optimisation choice for LK as it was useless
anyway since only GN was implemented.

This is a lazy fix for #130

Fix residuals for AAMs
Now AAMs are hardcoded to take the SSD. Also, renamed LSIntensity
to SSD.

Also, removed the optimisation choice for LK as it was useless
anyway since only GN was implemented.

jabooth and others added some commits Oct 14, 2014

Update base.py
Add a note about the limitations of residuals to SSD with AAMs
@jabooth

This comment has been minimized.

Member

jabooth commented Oct 14, 2014

Sounds good to me if @jalabort and @nontas are happy. +1.

@nontas

This comment has been minimized.

Member

nontas commented Oct 14, 2014

It looks good to me. +1

@jalabort

This comment has been minimized.

Member

jalabort commented Oct 14, 2014

This looks OK

jabooth added a commit that referenced this pull request Oct 14, 2014

@jabooth jabooth merged commit 7c482b3 into menpo:master Oct 14, 2014

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci The Travis CI build passed
Details

@jabooth jabooth removed the in progress label Oct 14, 2014

@patricksnape patricksnape deleted the patricksnape:residual_aam_fix branch Jan 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment