New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract patches on image #479

Merged
merged 2 commits into from Oct 16, 2014

Conversation

Projects
None yet
2 participants
@patricksnape
Contributor

patricksnape commented Oct 15, 2014

A couple of changes here making it look bigger than it is:

  • Standardise color to colour
  • Standardise center to centre
  • Move extract_local_patches on to image and add cythonised version

Addresses #455

@jabooth

This comment has been minimized.

Member

jabooth commented Oct 16, 2014

@patricksnape ohhh dear:

20,648 +++++ menpo/image/extract_patches.cpp

want to rm that, or squash?

patricksnape added some commits Oct 16, 2014

Change to British spelling
Change center to centre
Change color to colour
Fix some docstrings

Major changes happen in PCA, keyword arg center becomes centre
Move extract_pathes_local to image
Changes to a more efficient Cython version as well

@patricksnape patricksnape force-pushed the patricksnape:extract_patches_on_image branch from bd14117 to a6db61c Oct 16, 2014

@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Oct 16, 2014

Force pushed

jabooth added a commit that referenced this pull request Oct 16, 2014

@jabooth jabooth merged commit dc3d050 into menpo:master Oct 16, 2014

1 of 2 checks passed

continuous-integration/appveyor Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci The Travis CI build passed
Details

@jabooth jabooth removed the in progress label Oct 16, 2014

@jabooth jabooth deleted the patricksnape:extract_patches_on_image branch Oct 16, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment