New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spin out AAM, CLM, SDM, ATM and related code to menpofit #499

Merged
merged 5 commits into from Oct 28, 2014

Conversation

Projects
None yet
1 participant
@jabooth
Member

jabooth commented Oct 28, 2014

#453 proposed a restructuring of menpo into a small, tightly focused core library with a collection of specialized libraries depending on this core. menpo3d now contains all the complex dependencies for 3D work, menpodetect is a small specialized package that adds object detection to the Menpo family, and with this PR, menpofit will be the library in which all fitting code (SDM, CLM, AAM, ATM) and related methods can be developed. This has a number of nice benefits:

  1. Remove some of the more specialized (and more confusing) aspects of menpo into a specialized package. OrthoPDMs, ModelDrivenTransform and DX, DL, DP are nice interfaces that do a good job of keeping the code used in fitting clean, but they are highly specialized. This PR moves this complexity to menpofit keeping the core library focused
  2. Expensive unit tests removed from core Our test suite is now much faster for core menpo.
  3. menpofit can iterate independently from the core library at a greater speed. There are a number of re-factorings that we could make on the fit package - with this split we can make changes to menpofit in the confidence that we won't be fundamentally breaking things for other users of menpo.

From now on development of fitting algorithms in menpo will happen in the menpofit repository.

@jabooth jabooth added the in progress label Oct 28, 2014

@jabooth jabooth self-assigned this Oct 28, 2014

@jabooth jabooth added this to the 0.4.0 milestone Oct 28, 2014

@jabooth jabooth added the enhancement label Oct 28, 2014

jabooth added a commit that referenced this pull request Oct 28, 2014

Merge pull request #499 from jabooth/rmfit
spin out AAM, CLM, SDM, ATM and related code to menpofit

@jabooth jabooth merged commit fdb5e5d into menpo:master Oct 28, 2014

1 of 2 checks passed

continuous-integration/appveyor AppVeyor build failed
Details
continuous-integration/travis-ci The Travis CI build passed
Details

@jabooth jabooth removed the in progress label Oct 28, 2014

@jabooth jabooth deleted the jabooth:rmfit branch Oct 28, 2014

@nontas nontas referenced this pull request Oct 28, 2014

Merged

Remove menpofit widgets #501

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment