New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes pseudoinverse for Alignment Transforms #502

Merged
merged 4 commits into from Oct 31, 2014

Conversation

Projects
None yet
3 participants
@jalabort
Member

jalabort commented Oct 29, 2014

Fixes pseudoinverse for AlignmentTransforms.

@jabooth jabooth added the in progress label Oct 29, 2014

jalabort and others added some commits Oct 29, 2014

Make the image smaller before constraining
These avoids the memory error on the CI boxes.
@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Oct 30, 2014

OK :) Assuming @jabooth is happy with this, I am.

self_copy._h_matrix = self._h_matrix_pseudoinverse()
temp = self_copy.target
self_copy._source = temp
self_copy._target = self_copy.source

This comment has been minimized.

@jabooth

jabooth Oct 31, 2014

Member

we can always avoid this pattern in Python with tuple unpacking

self_copy._source, self_copy._target = self_copy._target, self_copy._source
@jabooth

This comment has been minimized.

Member

jabooth commented Oct 31, 2014

@jalabort once that minor style improvement is done we can bring this in, thanks! +1

@jalabort

This comment has been minimized.

Member

jalabort commented Oct 31, 2014

Done. Thanks for the tip @jabooth.

Once this one goes in all menpo and menpofit notebooks should work.

jabooth added a commit that referenced this pull request Oct 31, 2014

Merge pull request #502 from jalabort/pseudoinverse_fix
Fixes pseudoinverse for Alignment Transforms

@jabooth jabooth merged commit 88a89d2 into menpo:master Oct 31, 2014

1 of 2 checks passed

continuous-integration/appveyor Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci The Travis CI build passed
Details

@jabooth jabooth deleted the jalabort:pseudoinverse_fix branch Oct 31, 2014

@jabooth jabooth removed the in progress label Oct 31, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment